gitlab: add sched #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What failed: |
|
Since the ^^ above is a hwloc issue and not a sched issue we're going to ignore the valgrind test in our CI for now. |
wihobbs
force-pushed
the
add-sched
branch
3 times, most recently
from
b3c240d to
63d9f90
Compare
|
Dropped WIP. This is ready for a review. |
|
Whoops accidentally had two |
grondo
approved these changes
Feb 22, 2024
.gitlab-ci.yml
Outdated
| - git clone https://github.com/flux-framework/flux-sched | ||
| - cd flux-sched | ||
| - module load gcc | ||
| - ${CORE_INSTALL_PREFIX}/bin/flux start ./configure |
There was a problem hiding this comment.
I meant to mention that you could probably drop the start here and just use /path/to/flux ./configure. This is because when an explicit path is used with flux(1) it will execute its argument with the same environment as would have been passed to a subcommand.
Try that and see if it works if you'd like.
There was a problem hiding this comment.
Oh, that's handy, thanks! Fixed and pushed.
I also noticed that the commit message was out of date. Fixed on recent push.
Problem: We need to be testing flux-sched's integration with the rest of the framework, and we're not. Do that on corona and tioga since they're the system-instance clusters. Note that due to missing RPATH entries for certain libraries in Cray's compilers, this currently needs to be compiled with GCC. Also, the Valgrind test is temporarily exempted because it fails due to a memory leak in hwloc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being put up as WIP because there are some failures in the testsuite when run under the gitlab runners:
Notably, the valgrind test is failing, even when I rerun it. I don't really see what the "missing test plan" is all about...