Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: card grids #920

Merged
merged 11 commits into from
Jan 15, 2024
Merged

Conversation

Valastiri
Copy link
Member

@Valastiri Valastiri commented Dec 28, 2023

Summary

Implements the new card grid feature into various pages of our documentation.

  • Additional streamlining of pages.
  • Custom on hover CSS for card grids
  • At request of @Sleinmaster transitioned the documentation project page into it's own directory with two pages splitting the documentation.
    • Development Environment
    • Writing Documentation

Location

  • docs/fbw-a32nx/index.md
  • docs/fbw-a32nx/support/reported-issues.md
  • docs/dev-corner/development-projects

Screenshots

Before
image

After
image

Hover State
image

New Directory
image

Discord username (if different from GitHub):
valastiri

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 0:45am

@github-actions github-actions bot added support Changes to Support Directory repo Changes to Repo or Config labels Dec 28, 2023
@Valastiri
Copy link
Member Author

I think this is solid for now to get started and we can use this wherever applicable in the future.

@Valastiri Valastiri marked this pull request as ready for review January 14, 2024 18:21
@github-actions github-actions bot added the Review Required PR Check Label label Jan 14, 2024
@Valastiri
Copy link
Member Author

Actually apologies, I should write up a how 2 guide in the development corner on the use case scenario and how to implement it. Will re-draft until that's complete.

@Valastiri Valastiri marked this pull request as draft January 14, 2024 18:27
@Valastiri Valastiri removed the Review Required PR Check Label label Jan 14, 2024
@Sleinmaster
Copy link
Collaborator

Actually apologies, I should write up a how 2 guide in the development corner on the use case scenario and how to implement it. Will re-draft until that's complete.

Maybe you can split the documentation project page while doing so. I think currently it's getting too large.
Something like the Dev env setup should be on one page, the style and instructions like these on a second.

@Valastiri
Copy link
Member Author

Great idea ill incorporate that during the edits

@Valastiri Valastiri marked this pull request as ready for review January 15, 2024 05:56
@Valastiri Valastiri requested a review from Sleinmaster January 15, 2024 05:56
@github-actions github-actions bot added the Review Required PR Check Label label Jan 15, 2024
Copy link
Collaborator

@Sleinmaster Sleinmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only thing I would change, otherwise looks sound.

Co-authored-by: Sleinmaster <79196358+Sleinmaster@users.noreply.github.com>
@github-actions github-actions bot removed the Review Required PR Check Label label Jan 15, 2024
@github-actions github-actions bot merged commit 363a12c into flybywiresim:primary Jan 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved repo Changes to Repo or Config support Changes to Support Directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants