Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Streaming Decks #890

Merged
merged 6 commits into from
Jan 30, 2025
Merged

feat: Streaming Decks #890

merged 6 commits into from
Jan 30, 2025

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Nov 27, 2024

TL;DR

Show flyte deck when running phase and terminal phase (include failed)

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This pull request (PR) introduces several enhancements and fixes to the FlyteDeckButton and ExecutionNodeDeck components in the Flyte console. Here's a summary of the changes:

  1. FlyteDeckButton Component:

    • Added a RefreshIcon button to allow users to refresh the deck content.
    • Integrated a useDownloadLink hook to manage the download link for the deck.
    • Removed the disabled state from the button that opens the deck, allowing it to be clicked regardless of the node execution phase.
    • Updated the ExecutionNodeDeck component to accept a downloadLink prop.
  2. ExecutionNodeDeck Component:

    • Added error handling for NotFoundError to display a user-friendly message when the deck is not yet available.
    • Modified the component to use the downloadLink prop instead of creating a new instance within the component.

This PR enhances the FlyteDeckButton and ExecutionNodeDeck components to improve user interaction and error handling.

Tracking Issue

Follow-up issue

NA

Example

NEW FLYTEKIT, NO DECK, RUNNING With Deck, SUCCEED, and FAILED

OSS-STREAMING-DECK-small.mov

OLD FLYTEKIT, NO DECK, RUNNING With Deck, SUCCEED, and FAILED

OSS-STREAMING-DECK-OLD-FLYTEKIT-small.mov

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: Yicheng-Lu-llll <luyc58576@gmail.com>
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.61%. Comparing base (17ef806) to head (bb43675).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...etails/ExecutionDetailsActions/FlyteDeckButton.tsx 33.33% 4 Missing ⚠️
.../Executions/ExecutionDetails/ExecutionNodeDeck.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   54.62%   54.61%   -0.02%     
==========================================
  Files         585      585              
  Lines       15316    15321       +5     
  Branches     2801     2803       +2     
==========================================
+ Hits         8366     8367       +1     
- Misses       6950     6954       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier enabled auto-merge (squash) December 5, 2024 01:42
@Future-Outlier Future-Outlier enabled auto-merge (squash) December 5, 2024 01:43
@lyonlu13 lyonlu13 force-pushed the real-time-deck branch 2 times, most recently from e8ec978 to 2e5864b Compare December 5, 2024 01:50
Signed-off-by: Lyon Lu <lyon@union.ai>
@lyonlu13 lyonlu13 force-pushed the real-time-deck branch 3 times, most recently from 2f36663 to 24afebc Compare December 12, 2024 01:38
Signed-off-by: Lyon Lu <lyon@union.ai>
Future-Outlier and others added 2 commits January 22, 2025 11:04
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina changed the title [flyteconsole] Streaming Decks feat: Streaming Decks Jan 30, 2025
@Future-Outlier Future-Outlier merged commit 922bd3a into master Jan 30, 2025
10 of 12 checks passed
Copy link

welcome bot commented Jan 30, 2025

Congrats on merging your first pull request! 🎉

@Future-Outlier Future-Outlier deleted the real-time-deck branch January 30, 2025 19:39
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants