-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Streaming Decks #890
Conversation
Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: Yicheng-Lu-llll <luyc58576@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 54.62% 54.61% -0.02%
==========================================
Files 585 585
Lines 15316 15321 +5
Branches 2801 2803 +2
==========================================
+ Hits 8366 8367 +1
- Misses 6950 6954 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <eric901201@gmail.com>
e8ec978
to
2e5864b
Compare
Signed-off-by: Lyon Lu <lyon@union.ai>
2f36663
to
24afebc
Compare
Signed-off-by: Lyon Lu <lyon@union.ai>
24afebc
to
290f3ae
Compare
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Carina Ursu <carina@union.ai>
Congrats on merging your first pull request! 🎉 |
🎉 This PR is included in version 1.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Show flyte deck when running phase and terminal phase (include failed)
Type
Are all requirements met?
Complete description
This pull request (PR) introduces several enhancements and fixes to the FlyteDeckButton and ExecutionNodeDeck components in the Flyte console. Here's a summary of the changes:
FlyteDeckButton Component:
RefreshIcon
button to allow users to refresh the deck content.useDownloadLink
hook to manage the download link for the deck.disabled
state from the button that opens the deck, allowing it to be clicked regardless of the node execution phase.ExecutionNodeDeck
component to accept adownloadLink
prop.ExecutionNodeDeck Component:
NotFoundError
to display a user-friendly message when the deck is not yet available.downloadLink
prop instead of creating a new instance within the component.This PR enhances the FlyteDeckButton and ExecutionNodeDeck components to improve user interaction and error handling.
Tracking Issue
Follow-up issue
NA
Example
NEW FLYTEKIT, NO DECK, RUNNING With Deck, SUCCEED, and FAILED
OSS-STREAMING-DECK-small.mov
OLD FLYTEKIT, NO DECK, RUNNING With Deck, SUCCEED, and FAILED
OSS-STREAMING-DECK-OLD-FLYTEKIT-small.mov