prevent compile err for ReferenceWorkflow #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: machichima <nary12321@gmail.com>
machichima
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Code Review Agent Run #60519cActionable Suggestions - 0Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3102 +/- ##
===========================================
+ Coverage 51.81% 78.59% +26.77%
===========================================
Files 202 220 +18
Lines 21469 22235 +766
Branches 2766 2768 +2
===========================================
+ Hits 11125 17475 +6350
+ Misses 9735 3951 -5784
- Partials 609 809 +200 ☔ View full report in Codecov by Sentry. |
Signed-off-by: machichima <nary12321@gmail.com>
machichima
changed the title
Code Review Agent Run #faa8faActionable Suggestions - 1
Review Details
AI Code Review powered by |
flyte-bot
reviewed
Feb 1, 2025
Comment on lines
+536
to
+543
| remote_entity = remote.register_script( | ||
| my_wf, | ||
| project=PROJECT, | ||
| domain=DOMAIN, | ||
| image_config=ImageConfig.auto(img_name=IMAGE), | ||
| destination_dir=DEST_DIR, | ||
| source_path=MODULE_PATH, | ||
| ) |
There was a problem hiding this comment.
Consider reordering workflow registration and reference
Consider moving the register_script call before the reference_workflow decorator since the registration should happen before referencing the workflow.
Code suggestion
Check the AI-generated fix before applying
def test_execute_reference_workflow(register):
+ remote = FlyteRemote(Config.auto(config_file=CONFIG), PROJECT, DOMAIN)
+ remote_entity = remote.register_script(
+ my_wf,
+ project=PROJECT,
+ domain=DOMAIN,
+ image_config=ImageConfig.auto(img_name=IMAGE),
+ destination_dir=DEST_DIR,
+ source_path=MODULE_PATH,
+ )
@reference_workflow(
project=PROJECT,
domain=DOMAIN,
name="basic.basic_workflow.my_wf",
version=VERSION,
)
def my_wf(a: int, b: str) -> (int, str):
return a + 2, b + "world"
-
- remote = FlyteRemote(Config.auto(config_file=CONFIG), PROJECT, DOMAIN)
- remote_entity = remote.register_script(
- my_wf,
- project=PROJECT,
- domain=DOMAIN,
- image_config=ImageConfig.auto(img_name=IMAGE),
- destination_dir=DEST_DIR,
- source_path=MODULE_PATH,
- )
Code Review Run #faa8fa
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
Future-Outlier
approved these changes
Feb 1, 2025
3 tasks
| @@ -1275,6 +1275,8 @@ def register_script( | |||
| :param fast_package_options: Options to customize copy_all behavior, ignored when copy_all is False. | |||
| :return: | |||
| """ | |||
| if isinstance(entity, ReferenceWorkflow): | |||
There was a problem hiding this comment.
could we add all reference entities too? including launch plan and task? there's a base class for it.
There was a problem hiding this comment.
Sure! Let me have a look and open a new PR for it
UmerAhmad
pushed a commit
to UmerAhmad/flytekit
that referenced
this pull request
Feb 8, 2025
* fix: prevent compile err for ReferenceWorkflow Signed-off-by: machichima <nary12321@gmail.com> * test: ref workflow integration test with register script Signed-off-by: machichima <nary12321@gmail.com> --------- Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Umer Ahmad <umer2ahmad@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to flyteorg/flyte#6097
Why are the changes needed?
Return the entity itself without trying to compile if the entity is Reference workflow
What changes were proposed in this pull request?
How was this patch tested?
Integration test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
Fixed compilation error in remote.py by adding condition checks for ReferenceWorkflow entities. Enhanced the remote workflow testing framework with reference workflow testing capabilities, including new module imports and test cases. These changes ensure proper handling of reference workflow entities without compilation.Unit tests added: True
Estimated effort to review (1-5, lower is better): 1