Skip test_get_container_error_timestamp on windows #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Code Review Agent Run #cefaffActionable Suggestions - 0Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor
approved these changes
Feb 12, 2025
Code Review Agent Run #b5d975Actionable Suggestions - 0Review Details
AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
The test test_get_container_error_timestamp has been failing on windows since its introduction. We don't get any signal from it, mainly because no one is really going to use pytorch on windows.
What changes were proposed in this pull request?
Skip a particular test on windows.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
Added Windows-specific skip condition for test_get_container_error_timestamp test to address unreliable timestamp granularity issues. Implementation includes sys module import for platform detection and conditional test execution to handle persistent Windows test failures.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1