Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ray documentation based on pod template changes #1765

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Oct 27, 2024

Updates the documentation for recent Ray plugin changes

@Sovietaced Sovietaced force-pushed the ray-docs branch 2 times, most recently from 86ba755 to 328138d Compare February 2, 2025 08:26
@Sovietaced Sovietaced changed the title Cleanup ray docs to reflect current functionality Update Ray documentation based on pod template changes Feb 2, 2025
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
davidmirror-ops
davidmirror-ops previously approved these changes Feb 6, 2025
Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions otherwise LGTM
Thank you!

examples/ray_plugin/ray_plugin/ray_example.py Outdated Show resolved Hide resolved
examples/ray_plugin/ray_plugin/ray_example.py Outdated Show resolved Hide resolved
examples/ray_plugin/ray_plugin/ray_example.py Outdated Show resolved Hide resolved
Co-authored-by: David Espejo <82604841+davidmirror-ops@users.noreply.github.com>
Signed-off-by: Jason Parraga <Sovietaced@gmail.com>
Sovietaced and others added 2 commits February 8, 2025 10:38
Co-authored-by: David Espejo <82604841+davidmirror-ops@users.noreply.github.com>
Signed-off-by: Jason Parraga <Sovietaced@gmail.com>
Co-authored-by: David Espejo <82604841+davidmirror-ops@users.noreply.github.com>
Signed-off-by: Jason Parraga <Sovietaced@gmail.com>
@Sovietaced
Copy link
Contributor Author

@davidmirror-ops Thanks for proof reading my docs. Shouldn't have written them at mignight lol

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidmirror-ops davidmirror-ops merged commit 7dc2890 into flyteorg:master Feb 10, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants