Pak 3984 #20
Pak 3984 #20
Conversation
Jonifmi
commented
Sep 26, 2024
Jonifmi
commented
- Refactored code for adding warning symbols to make it easier to add new symbols.
- Added placeholder icons for newly introduced icons.
- General refactoring for better maintainability and easier future development.
| ]; | ||
|
|
||
| // Create table rows for the legend | ||
| for (let i = 0; i < levels.length; i += 2) { |
There was a problem hiding this comment.
(With my not-so-up-to-date skills), is it this syntax for incrementing OK, and is it incremented by 2 on purpose?
There was a problem hiding this comment.
My bad. Yes it is on purpose. After reading the code :)
There was a problem hiding this comment.
Yeah, in this case, however, +1 would give the same result
| : symbolPath + 'surf-height.png'; | ||
| } else { | ||
| // Handle events based on eventRaw or eventSelector | ||
| let eventMapping = [ |
There was a problem hiding this comment.
Maybe consider sorting alphabetically by match, or perhaps by icon. Or maybe if there is some more generic event type to be used here. E.g. sort wave and tsunami and high tide and other "watery evens" close to each other.
There was a problem hiding this comment.
Some sort of manual arrangement would be practical and i'll think about a good solution. Alphabetical order doesn't work because, for example, in cases of flooding, the "flash flood" warning would be before more exact warning types, and the function would pick it instead of checking for exact warning types after that.
