update how WAKEPY_FAKE_SUCCESS works - only affects Modes #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make checking the 'should fake success' part of selecting the methods
* test should_fake_success and add_fake_success_if_required
The WAKEPY_FAKE_SUCCESS method may not ever fail. If it is included, it will always success
fohrloop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WakepyFakeSuccess method to the start of the methods list. This means that any Mode is quaranteed to be succesful with
WAKEPY_FAKE_SUCCESS, but there's no guarantee for any particular Method (using Methods separately is not part of the public API of wakepy, so this does not matter)