Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional mypy runs on 3.7, 3.8, 3.9, 3.11 and 3.12 + fix mypy checks on py37-py39 #265

Merged
merged 17 commits into from
Apr 21, 2024

Conversation

fohrloop
Copy link
Owner

@fohrloop fohrloop commented Apr 21, 2024

As wakepy is a type annotated library and supports python versions from 3.7 to 3.12, and supported type annotations depend on the used version of python, the mypy checks should be running also on versions other than 3.10.

Added mypy checks to CI pipelines, running on Python 3.7, 3.8, 3.9, 3.11 and 3.12

This revealed that the static type checks were failing on versions 3.7-3.9. Fixed the errors.

@fohrloop fohrloop force-pushed the run-mypy-on-multiple-versions-of-python branch from bbfffc1 to 9e17b67 Compare April 21, 2024 14:55
@fohrloop fohrloop changed the title make mypy run on 3.7, 3.10 and 3.12 Additional mypy runs on 3.7, 3.8, 3.9, 3.11 and 3.12 + fix mypy checks on py37-py39 Apr 21, 2024
@fohrloop fohrloop merged commit 9197540 into dev Apr 21, 2024
17 checks passed
@fohrloop fohrloop deleted the run-mypy-on-multiple-versions-of-python branch April 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant