Fix: org.gnome.SessionManager RuntimeError (Issue 276) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fohrloop
force-pushed
the
issue-276-gnome-sessionmanager
branch
from
8e5d8d8 to
45d8791
Compare
fohrloop
changed the title
fohrloop
added a commit
that referenced
this pull request
May 18, 2024
fohrloop
added a commit
that referenced
this pull request
May 18, 2024
…77) (#282) Previously: Using the org.gnome.SessionManager method repeatedly would freeze system in 400-600 iterations. Now: Get to ~2000 iterations before system freezes. Contents -------- * Dbus connections are now closed. In addition, gc.collect() is called each time connection is closed (at least for now), as adding it helped to get more iteration cycles. * Add warning to docs of org.gnome.SessionManager * bonus: Some refactoring of dbus adapter tests + remove the temporary warning ignore introduced in #278.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error with Gnome SessionManager based keepawake (#276)
DBus Adapters
All DBusAdapters now have to keep reference to the connection(s). This was required as if the connection instance was garbage collected, the inhibit cookie created by Gnome SessionManager was wiped.
The DBusAdapter class now has _get_connection(bus) method or getting a connection instance for an adapter.
The DBusAdapter subclasses now must implement a _create_new_connection(bus) method.
Other
Temporarily ignore warnings in tests/integration/conftest.py while running gc.collect(). This should be addressed later (likely as part of #277)