Skip to content

Commit

Permalink
UIEH-1397: The list of packages is no longer cut off in the modal win…
Browse files Browse the repository at this point in the history
…dow. (#1697)
  • Loading branch information
Dmytro-Melnyshyn authored and BogdanDenis committed Nov 9, 2023
1 parent bcdb0ed commit 889fff3
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 17 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change history for ui-eholdings

## [9.0.2] (IN PROGRESS)

* The list of packages is no longer cut off in the modal window. (UIEH-1397)

## [9.0.1] (https://github.com/folio-org/ui-eholdings/tree/v9.0.1) (2023-11-03)

* Fix deleting and then saving custom embargo. (UIEH-1394)
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import {
Icon,
} from '@folio/stripes/components';

import css from './package-select-field.css';

function validate(value) {
return value ? undefined : <FormattedMessage id="ui-eholdings.validate.errors.packageSelect.required" />;
}
Expand All @@ -35,13 +33,13 @@ const PackageSelectField = ({
};

return (
<div
data-test-eholdings-package-select-field
className={css.packageSelectFieldContainer}
>
<div data-test-eholdings-package-select-field>
<Field
name="packageId"
component={Selection}
popper={{
portal: document.getElementById('ModuleContainer'),
}}
label={label}
ariaLabel={label}
validate={validate}
Expand All @@ -53,14 +51,6 @@ const PackageSelectField = ({
data-testid="package-select-field"
loading={loadingOptions}
loadingMessage={<Icon icon="spinner-ellipsis" />}
tether={{
constraints: [
{
to: 'window',
attachment: 'together',
},
],
}}
/>
</div>
);
Expand Down
4 changes: 4 additions & 0 deletions src/components/title/show/title-show.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.add-to-custom-package-button {
margin: 1rem 0 0;
}

.addTitleModalContent {
overflow: visible;
}
1 change: 1 addition & 0 deletions src/components/title/show/title-show.js
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,7 @@ class TitleShow extends Component {
id="eholdings-custom-package-modal"
wrappingElement="form"
enforceFocus={false}
contentClass={styles.addTitleModalContent}
footer={(
<ModalFooter>
<Button
Expand Down

0 comments on commit 889fff3

Please sign in to comment.