UIEH-1436: Rename permissions to match the naming convention. (#1743)

folio-org · Oct 30, 2024 · 9006788 · 9006788
1 parent 4645e2f
commit 9006788
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 * *BREAKING* Upgrade `eholdings` to `4.0`. Change permission `kb-ebsco.kb-credentials.item.get` to `kb-ebsco.kb-credentials.key.item.get` and `kb-ebsco.kb-credentials.uc.item.get` to `kb-ebsco.kb-credentials.uc.key.item.get`. (UIEH-1431)
 * Return permissions: `kb-ebsco.kb-credentials.uc.item.get`, `kb-ebsco.kb-credentials.item.get`. (UIEH-1434)
 * migrate to shared CI workflows. (UIEH-1429)
+* Rename permissions to match the naming convention. (UIEH-1436)
 
 ## [9.1.1] (https://github.com/folio-org/ui-eholdings/tree/v9.1.1) (2024-03-24)
 

diff --git a/package.json b/package.json
@@ -147,7 +147,8 @@
         ]
       },
       {
-        "permissionName": "ui-eholdings.app.enabled",
+        "permissionName": "ui-eholdings.app.view",
+        "replaces": ["ui-eholdings.app.enabled"],
         "subPermissions": [
           "module.eholdings.enabled"
         ],
@@ -222,8 +223,9 @@
         ]
       },
       {
-        "permissionName": "ui-eholdings.package-title.select-unselect",
+        "permissionName": "ui-eholdings.package-title.select-unselect.execute",
         "displayName": "eHoldings: Can select/unselect packages and titles to/from your holdings",
+        "replaces": ["ui-eholdings.package-title.select-unselect"],
         "visible": true,
         "subPermissions": [
           "module.eholdings.enabled",
@@ -244,8 +246,9 @@
         ]
       },
       {
-        "permissionName": "ui-eholdings.titles-packages.create-delete",
+        "permissionName": "ui-eholdings.titles-packages.create-delete.manage",
         "displayName": "eHoldings: Can create and delete custom packages and titles",
+        "replaces": ["ui-eholdings.titles-packages.create-delete"],
         "visible": true,
         "subPermissions": [
           "module.eholdings.enabled",

diff --git a/src/components/package/edit-managed/managed-package-edit.js b/src/components/package/edit-managed/managed-package-edit.js
@@ -202,7 +202,7 @@ const ManagedPackageEdit = ({
 
   const getActionMenu = () => {
     const isAddButtonNeeded = !packageSelected || model.isPartiallySelected;
-    const hasSelectPermission = stripes.hasPerm('ui-eholdings.package-title.select-unselect');
+    const hasSelectPermission = stripes.hasPerm('ui-eholdings.package-title.select-unselect.execute');
 
     if (!hasSelectPermission) return null;
 

diff --git a/src/components/package/selection-status.js b/src/components/package/selection-status.js
@@ -24,7 +24,7 @@ const SelectionStatus = ({
     >
       <SelectionStatusMessage model={model} />
       <br />
-      <IfPermission perm="ui-eholdings.package-title.select-unselect">
+      <IfPermission perm="ui-eholdings.package-title.select-unselect.execute">
         <SelectionStatusButton
           model={model}
           onAddToHoldings={onAddToHoldings}

diff --git a/src/components/resource/components/edit/holding-status/edit-holding-status.js b/src/components/resource/components/edit/holding-status/edit-holding-status.js
@@ -39,7 +39,7 @@ const EditHoldingStatus = ({
   const renderToggleSelectionStatusButton = () => {
     if ((!resourceSelected && !isSelectInFlight) || (!model.isSelected && isSelectInFlight)) {
       return (
-        <IfPermission perm="ui-eholdings.package-title.select-unselect">
+        <IfPermission perm="ui-eholdings.package-title.select-unselect.execute">
           <Button
             buttonStyle="primary"
             onClick={handleToggleResourceHoldings}

diff --git a/src/components/resource/edit-custom-title/resource-edit-custom-title.js b/src/components/resource/edit-custom-title/resource-edit-custom-title.js
@@ -147,7 +147,7 @@ const ResourceEditCustomTitle = ({
   };
 
   const getActionMenu = () => {
-    const hasSelectPermission = stripes.hasPerm('ui-eholdings.package-title.select-unselect');
+    const hasSelectPermission = stripes.hasPerm('ui-eholdings.package-title.select-unselect.execute');
 
     if (!hasSelectPermission || !resourceSelected) {
       return null;

diff --git a/src/components/resource/edit-managed-title/resource-edit-managed-title.js b/src/components/resource/edit-managed-title/resource-edit-managed-title.js
@@ -140,7 +140,7 @@ const ResourceEditManagedTitle = ({
   };
 
   const getActionMenu = () => {
-    const hasSelectPermission = stripes.hasPerm('ui-eholdings.package-title.select-unselect');
+    const hasSelectPermission = stripes.hasPerm('ui-eholdings.package-title.select-unselect.execute');
 
     if (!hasSelectPermission) {
       return null;

diff --git a/src/constants/permissionNames.js b/src/constants/permissionNames.js
@@ -1,5 +1,5 @@
 export const RECORDS_EDIT_PERMISSION = 'ui-eholdings.records.edit';
 
-export const TITLES_PACKAGES_CREATE_DELETE_PERMISSION = 'ui-eholdings.titles-packages.create-delete';
+export const TITLES_PACKAGES_CREATE_DELETE_PERMISSION = 'ui-eholdings.titles-packages.create-delete.manage';
 
-export const PACKAGE_TITLE_SELECT_UNSELECT_PERMISSION = 'ui-eholdings.package-title.select-unselect';
+export const PACKAGE_TITLE_SELECT_UNSELECT_PERMISSION = 'ui-eholdings.package-title.select-unselect.execute';
diff --git a/translations/ui-eholdings/en.json b/translations/ui-eholdings/en.json
@@ -619,14 +619,14 @@
     "selection-modal.buttonWorking": "Removing...",
     "selection-modal.buttonConfirm": "Yes, remove",
 
-    "permission.app.enabled": "eHoldings: Can view providers, packages, titles detail records",
+    "permission.app.view": "eHoldings: Can view providers, packages, titles detail records",
     "permission.settings.enabled": "Settings (eHoldings): View settings",
     "permission.settings.kb": "Settings (eHoldings): Can create, edit, and view knowledge base credentials",
     "permission.settings.kb.delete": "Settings (eHoldings): Can delete knowledge base credentials",
     "permission.settings.root-proxy": "Settings (eHoldings): configure root proxy setting",
-    "permission.package-title.select-unselect": "eHoldings: Can select/unselect packages and titles to/from your holdings",
+    "permission.package-title.select-unselect.execute": "eHoldings: Can select/unselect packages and titles to/from your holdings",
     "permission.records.edit": "eHoldings: Can edit providers, packages, titles detail records",
-    "permission.titles-packages.create-delete": "eHoldings: Can create and delete custom packages and titles",
+    "permission.titles-packages.create-delete.manage": "eHoldings: Can create and delete custom packages and titles",
     "permission.costperuse.view": "eHoldings: Can view Usage & analysis data for packages, titles and resources",
     "permission.settings.access-types.all": "Settings (eholdings): Can create, edit, view, and delete access status types",
     "permission.settings.access-types.create-edit": "Settings (eholdings): Can create, edit, and view access status types",