UIEH-1439: Pass the AsyncFilter property to the Selection component of packages.
#1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
requested review from
BogdanDenis,
mariia-aloshyna and
Terala-Priyanka
|
mariia-aloshyna
approved these changes
Nov 6, 2024
Terala-Priyanka
approved these changes
Nov 7, 2024
BogdanDenis
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Selectioncomponent was rewritten some time ago, this was a breaking change to the eholdings packages implementation, which caused the API to call infinitely. The solution is to pass theasyncFilterproperty, since filtering should call new packages when the filter changes. 200ms delay was added in theSelectioncomponent for API calls, so I reduced the delay in eholdings component.Issues
UIEH-1439
Approach
TODOS and Open Questions
Learning
Screenshots
2024-11-05_15h54_56.mp4