🥅 Handle unexpected detector responses #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
pmcjr
pushed a commit
to pmcjr/fms-guardrails-orchestrator
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #96 - if a detector is not returning the expected number of responses [one per chunk] we want to surface an error rather than provide incorrect results
Error log example -
2024-06-25T20:17:15.224226Z ERROR fms_guardrails_orchestr8::orchestrator: unary task failed request_id=5718f002-1621-4667-9e6f-53b28e048e5b error=Detector xyz did not return expected number of responsesUser sees
{"code":500,"details":"unexpected error occured while processing request"}[since this is not a user-fixable error]Closes: #100