Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add axum-test package for integration tests #188

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add axum-test package for integration tests #188

merged 1 commit into from
Sep 10, 2024

Conversation

mdevino
Copy link
Collaborator

@mdevino mdevino commented Sep 9, 2024 •
edited
Loading

This addresses #189 , which is a preparation for #115. This PR...

  • Adds the axum-test package as a test dependency.
  • Creates a canary test that invokes the /health endpoint.

Note: I had to run cargo update to fix building problems.

@mdevino
Add axum-test package for integration tests.
ca512c7 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Copy link
Collaborator Author

mdevino commented Sep 9, 2024

I forgot to mention, but axum-test lincense's is MIT.

evaline-ju
evaline-ju approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evaline-ju evaline-ju merged commit 5426f05 into foundation-model-stack:main Sep 10, 2024
2 checks passed
@mdevino mdevino mentioned this pull request Sep 12, 2024
Closed
2 tasks
@mdevino mdevino deleted the axum-test branch September 12, 2024 00:26
@pscoro pscoro mentioned this pull request Sep 17, 2024
Merged
@evaline-ju evaline-ju linked an issue Sep 27, 2024 that may be closed by this pull request
Add testing framework for integration tests #189
Closed
2 tasks
mdevino added a commit to mdevino/fms-guardrails-orchestrator that referenced this pull request Oct 11, 2024
@mdevino
Add axum-test package for integration tests. (foundation-model-stack#188
38247df 
)

Signed-off-by: Mateus Devino <mdevino@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evaline-ju evaline-ju evaline-ju approved these changes

@gkumbhat gkumbhat Awaiting requested review from gkumbhat gkumbhat is a code owner

@declark1 declark1 Awaiting requested review from declark1 declark1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing framework for integration tests Build error propagating from Tower
2 participants
@mdevino @evaline-ju