Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed most of the warnings from Dockerfile when running docker build #301

Conversation

resoluteCoder
Copy link
Collaborator

This PR removes most of the warnings when building the container image using docker build.

Previous Warnings:

 10 warnings found (use --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 8)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 25)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 38)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 42)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 46)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 51)
 - UndefinedVar: Usage of undefined variable '$CONFIG_FILE' (line 28)
 - UndefinedVar: Usage of undefined variable '$CONFIG_FILE' (line 54)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 66)
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 68)

Currently:

 2 warnings found (use --debug to expand):
 - UndefinedVar: Usage of undefined variable '$CONFIG_FILE' (line 28)
 - UndefinedVar: Usage of undefined variable '$CONFIG_FILE' (line 54)

Signed-off-by: resoluteCoder <resolutecoder@gmail.com>
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the update!

@evaline-ju evaline-ju merged commit 75299e3 into foundation-model-stack:main Feb 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants