Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for /api/v2/text/detection/content #314

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

Integration tests for /api/v2/text/detection/content #314

wants to merge 76 commits into from

Conversation

mdevino
Copy link
Collaborator

@mdevino mdevino commented Feb 25, 2025

This addresses #289 with the test cases listed here.

mdevino and others added 30 commits February 24, 2025 18:28
@mdevino
Refactor common integration test code
8b4df02 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
/detection/content base test case
798b730 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Replace json macros with strong types
c02c653 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update test detector name to mention whole_doc_chunker
2c80ddc 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Testing mock for chunker gRPC call
2037533 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update detection_content.rs::test_single_detection() to include detec…
64ef86a 
…tor_id

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update detection_content.rs::test_single_detection_whole_doc() mocks …
a208f80 
…to use random ports

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Make test_single_detection_whole_doc() more meaningful
e30a2df 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add test case: detection_content.rs::test_single_detection_sentence_c…
7b4f0ac 
…hunker

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Move specific code back to canary_test.rs
01aa131 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
refactor: extract constants
6af1ac4 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
refactor: move grpc server macros to tests common module
1cd39d0 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add copyright notice to common test module
33839b1 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
refactor: create function for orchestrator config
6eaf9fe 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add chunkers logic to create_orchestrator_shared_state()
17435b0 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Change mocktail source to IBM git repo
b3706ac 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Refactor chunker unary endpoint as constant
f6e5408 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update create_orchestrator_shared_state() to return Result
14325e8 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove unwrap() calls
6ab815b 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Allow dead code on test common file
b51eb12 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove unneeded changes in canary_test.rs
4cd10d6 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add copyright text to canary_test.rs
61b1757 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove allow macro from tests/common/mod.rs
4c21b76 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
wip: test isolated NLP streaming call
d6c9172 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Break common test module into multiple files
769df32 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Test NLP generation stremaing call
99e4544 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: streaming no detectors
f55765b 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@declark1 @mdevino
Add MockOrchestratorServer to replace usage of TestServer, add EventS…
a8cafe5 
…ource example, add custom SseStream wrapper (wip)

Signed-off-by: declark1 <44146800+declark1@users.noreply.github.com>
@mdevino
Refactor test util.rs module into orchestrator.rs
fc65700 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove old create_orchestrator_shared_state()
2b3fed6 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Rename tests/test.config.yaml
69d3363 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Document test cases on comments
85fd281 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add assertions to make sure no detections are returned
e5390d2 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino mdevino mentioned this pull request Feb 27, 2025
Open
@mdevino mdevino force-pushed the text_content_detection_integration_testing branch from 621b31c to 4c84aa5 Compare February 27, 2025 15:44
@mdevino
Update mocktail to 0.1.2-alpha
6c46d6c 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino mdevino force-pushed the text_content_detection_integration_testing branch from 4c84aa5 to c5fddc4 Compare February 28, 2025 13:24
mdevino added 18 commits March 3, 2025 09:02
@mdevino
Fix comments
517e980 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Refactor common integration test code
6adcac9 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
/detection/content base test case
0c07875 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Rename tests/detection_content.rs
4762954 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_no_detection_whole_doc()
09b2510 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_no_detection_sentence_chunker()
aba1e1c 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_detector_returns_503()
70be320 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_detector_returns_404()
9f1100f 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_detector_returns_500()
203bceb 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_detector_returns_non_compliant_message()
4124714 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_chunker_returns_an_error()
f997f1d 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_request_with_extra_fields_returns_422()
5aa899a 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_request_missing_detectors_field_returns_422()
cf3e8da 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_request_missing_content_field_returns_422()
fb5b5da 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: test_request_with_empty_detectors_field_returns_422()
d3215bc 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add missing import to canary_test.rs
adb7b50 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update tests to use mocktail 0.1.2-alpha
2ce212c 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add comments to text_content tests
bd4e07a 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino mdevino force-pushed the text_content_detection_integration_testing branch from 61455f7 to bd4e07a Compare March 3, 2025 12:04
@mdevino mdevino marked this pull request as ready for review March 3, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkumbhat gkumbhat Awaiting requested review from gkumbhat gkumbhat is a code owner

@evaline-ju evaline-ju Awaiting requested review from evaline-ju evaline-ju is a code owner

@declark1 declark1 Awaiting requested review from declark1 declark1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdevino @declark1