Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for input detections in /api/v2/text/detection/context/ #319

Open
wants to merge 104 commits into
base: main
Choose a base branch
from
Open

Integration tests for input detections in /api/v2/text/detection/context/ #319

wants to merge 104 commits into from

Conversation

mdevino
Copy link
Collaborator

@mdevino mdevino commented Feb 26, 2025

This addresses #316.

mdevino and others added 30 commits February 24, 2025 18:28
@mdevino
Refactor common integration test code
8b4df02 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
/detection/content base test case
798b730 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Replace json macros with strong types
c02c653 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update test detector name to mention whole_doc_chunker
2c80ddc 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Testing mock for chunker gRPC call
2037533 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update detection_content.rs::test_single_detection() to include detec…
64ef86a 
…tor_id

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update detection_content.rs::test_single_detection_whole_doc() mocks …
a208f80 
…to use random ports

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Make test_single_detection_whole_doc() more meaningful
e30a2df 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add test case: detection_content.rs::test_single_detection_sentence_c…
7b4f0ac 
…hunker

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Move specific code back to canary_test.rs
01aa131 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
refactor: extract constants
6af1ac4 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
refactor: move grpc server macros to tests common module
1cd39d0 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add copyright notice to common test module
33839b1 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
refactor: create function for orchestrator config
6eaf9fe 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add chunkers logic to create_orchestrator_shared_state()
17435b0 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Change mocktail source to IBM git repo
b3706ac 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Refactor chunker unary endpoint as constant
f6e5408 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update create_orchestrator_shared_state() to return Result
14325e8 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove unwrap() calls
6ab815b 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Allow dead code on test common file
b51eb12 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove unneeded changes in canary_test.rs
4cd10d6 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add copyright text to canary_test.rs
61b1757 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove allow macro from tests/common/mod.rs
4c21b76 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
wip: test isolated NLP streaming call
d6c9172 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Break common test module into multiple files
769df32 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Test NLP generation stremaing call
99e4544 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: streaming no detectors
f55765b 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@declark1 @mdevino
Add MockOrchestratorServer to replace usage of TestServer, add EventS…
a8cafe5 
…ource example, add custom SseStream wrapper (wip)

Signed-off-by: declark1 <44146800+declark1@users.noreply.github.com>
@mdevino
Refactor test util.rs module into orchestrator.rs
fc65700 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Remove old create_orchestrator_shared_state()
2b3fed6 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
mdevino added 25 commits March 3, 2025 09:03
@mdevino
test case: detection_on_generation::test_detector_returns_404()
830f9a1 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: detection_on_generation::test_detector_returns_500()
bce22ca 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: detection_on_generation::test_detector_returns_non_complia…
f329e02 
…nt_message()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: detection_on_generation::test_request_with_extra_fields_re…
d894740 
…turns_422()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Change response logs to pretty
8c10221 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: detection_on_generation::test_request_missing_prompt_retur…
55a12f0 
…ns_422()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: detection_on_generation::test_request_missing_generated_te…
68d680d 
…xt_returns_422()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: detection_on_generation::test_request_missing_detectors_re…
0151e99 
…turns_422()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: detection_on_generation::test_request_with_empty_detectors…
e1f4a8b 
…_returns_422()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add comments to detection_on_generation tests
42d7caa 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Fix comments
69777f4 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_detection_below_default_thres…
89d6adc 
…hold_is_not_returned()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_detection_above_default_thres…
10a03ef 
…hold_is_returned()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_detectior_returns_503()
4577327 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_detectior_returns_404()
5d43895 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_orchestrator_receives_a_reque…
a0e22e8 
…st_with_extra_fields()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_orchestrator_receives_a_reque…
07c9044 
…st_missing_content()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_orchestrator_receives_a_reque…
2fcd89f 
…st_missing_context()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_orchestrator_receives_a_reque…
b1c132e 
…st_missing_context_type()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_orchestrator_receives_a_reque…
e5e38e2 
…st_with_invalid_context_type()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_orchestrator_receives_a_reque…
08e4e29 
…st_missing_detectors()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
test case: context_docs_detection::test_orchestrator_receives_a_reque…
d807372 
…st_with_invalid_detectors()

Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Update tests to use mocktail 0.1.2-alpha
5bfc573 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Add comments to context_docs tests
cb817bc 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino
Fix comments
a0da2c7 
Signed-off-by: Mateus Devino <mdevino@ibm.com>
@mdevino mdevino force-pushed the context_docs_integration_tests branch from c125019 to a0da2c7 Compare March 3, 2025 12:05
@mdevino mdevino marked this pull request as ready for review March 3, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkumbhat gkumbhat Awaiting requested review from gkumbhat gkumbhat is a code owner

@evaline-ju evaline-ju Awaiting requested review from evaline-ju evaline-ju is a code owner

@declark1 declark1 Awaiting requested review from declark1 declark1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdevino @declark1