Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍💻 Replace content endpoint with batch endpoint #49

Merged

Conversation

gkumbhat
Copy link
Collaborator

@gkumbhat gkumbhat commented May 24, 2024

Changes

  • Replace content endpoint to support batch operation by default.

Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
@gkumbhat gkumbhat force-pushed the convert_content_to_batch branch from 3c100af to 7266b39 Compare May 24, 2024 20:10
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to update the L13 description to capture that this is multiple texts

@gkumbhat
Copy link
Collaborator Author

gkumbhat commented May 24, 2024

I think L13 is still accurate since this endpoint is designed for detectors that work on user prompt or generated text. Its just that instead of 1 document, now the API accepts multiple documents.

This information probably belongs in the description of ContentAnalysisHttpRequest.contents

@evaline-ju
Copy link
Collaborator

This information probably belongs in the description of ContentAnalysisHttpRequest.contents

Potentially, I think it's worth calling out that this is now texts or multiple "content"s in some form

Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestion!

Co-authored-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
@gkumbhat gkumbhat merged commit 352d918 into foundation-model-stack:main May 24, 2024
1 check passed
@gkumbhat gkumbhat deleted the convert_content_to_batch branch May 24, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants