Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use windows-2025 #978

Merged
merged 1 commit into from
Dec 19, 2024
Merged

ci: use windows-2025 #978

merged 1 commit into from
Dec 19, 2024

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Dec 19, 2024

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.0%. Comparing base (816a069) to head (b4deb3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #978   +/-   ##
=====================================
  Coverage   93.0%   93.0%           
=====================================
  Files         37      37           
  Lines        994     994           
  Branches      98      98           
=====================================
  Hits         925     925           
  Misses        55      55           
  Partials      14      14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner
Copy link
Collaborator Author

Tests run faster with windows-2025:

Job Run time
windows (3.9) 6m 18s
windows (3.10) 5m 52s
windows (3.11) 6m 29s
windows (3.12) 5m 3s
windows (3.13) 5m 13s
windows (pypy3.10) 8m 0s
Job Run time
windows (3.9) 6m 47s
windows (3.10) 8m 21s
windows (3.11) 8m 50s
windows (3.12) 7m 10s
windows (3.13) 6m 41s
windows (pypy3.10) 9m 7s

But there is an error on the dry-run release job when building wheels for aarch64:

C:\hostedtoolcache\windows\Python\3.13.1\x64\libs\python3.lib : warning LNK4272: library machine type 'x64' conflicts with target machine type 'ARM64'␍
D:\a\deptry\deptry\target\aarch64-pc-windows-msvc\release\deps\deptry.dll : fatal error LNK1120: 98 unresolved externals␍

This will need investigation.

@mkniewallner
Copy link
Collaborator Author

But there is an error on the dry-run release job when building wheels for aarch64:

C:\hostedtoolcache\windows\Python\3.13.1\x64\libs\python3.lib : warning LNK4272: library machine type 'x64' conflicts with target machine type 'ARM64'␍
D:\a\deptry\deptry\target\aarch64-pc-windows-msvc\release\deps\deptry.dll : fatal error LNK1120: 98 unresolved externals␍

This will need investigation.

Actually, same issue happens with windows-2022, so probably not related, but let's hold off from merging this until we figure out what's going on.

@mkniewallner mkniewallner marked this pull request as ready for review December 19, 2024 22:58
@mkniewallner mkniewallner merged commit 08e2e40 into main Dec 19, 2024
41 checks passed
@mkniewallner mkniewallner deleted the ci/use-windows-2025 branch December 19, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant