Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to fractal-server 1.3 and fractal-tasks-core 0.10 #55

Merged
merged 8 commits into from
Jun 16, 2023

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jun 16, 2023

No description provided.

@tcompa tcompa changed the title Update examples to fractal-server 1.3 and fractal-tasks-core 0.10.0 Update examples to fractal-server 1.3 and fractal-tasks-core 0.10 Jun 16, 2023
@tcompa tcompa marked this pull request as draft June 16, 2023 07:02
@tcompa
Copy link
Collaborator Author

tcompa commented Jun 16, 2023

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 16, 2023

I can't remember what is the expected output of example 03 (the multiplexing one). I've updated it, but I'm not sure that the result is fine.

This is e.g. the output of napari --plugin napari-ome-zarr tmp_multiplex-3/20200812-CardiomyocyteDifferentiation14-Cycle1_mip.zarr/B/03/:

Screenshot from 2023-06-16 14-12-36

@jluethi does it match with what we would expect? I think this was just due to napari not supporting multiplex, right?

@jluethi
Copy link
Collaborator

jluethi commented Jun 16, 2023

There should be 3 images in the B/03/ folder
1 with 1 channel. 1 with 2 channels, 1 with 3.
If you open them individually as path/to/B/03/0, path/to/B/03/1 and path/to/B/03/2, you'll see them.
This looks correct for the first.

Also, another reason why we eventually should have some minimal form of #37 :)

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 16, 2023

Perfect, thanks. I confirm the behavior is the expected one.

@jluethi
Copy link
Collaborator

jluethi commented Jun 16, 2023

Also, let's merge this branch after the example 3 again. Just ran into the failing example 01 (because of the workflow yaml paths) and it's useful to have example 01 working in main for easy testing of new setups :)

@tcompa tcompa marked this pull request as ready for review June 16, 2023 12:26
@tcompa tcompa merged commit c041575 into main Jun 16, 2023
@tcompa tcompa deleted the update_examples_for_1_3_0 branch June 16, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants