bug fix on date effective skills

frePPLe · Feb 11, 2022 · 07c9091 · 07c9091
1 parent da6fa6c
commit 07c9091
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/doc/release-notes.rst b/doc/release-notes.rst
@@ -17,6 +17,13 @@ The main target is to refresh the component stack:
 These changes will be made gradual over a couple of releases. For instance, 6.20.0 will
 support both Ubuntu 18 as well as Ubuntu 20.
 
+6.20.1 (2022/2/11)
+==================
+
+.. rubric:: Production planning
+
+- | Bug fix: the effectivity dates were not verified correctly in some corner
+    cases.
 6.20.0 (2022/1/22)
 ==================
 

diff --git a/src/model/operationplan.cpp b/src/model/operationplan.cpp
@@ -2146,7 +2146,7 @@ double OperationPlan::getEfficiency(Date d) const {
       for (Resource::memberRecursiveIterator mmbr(h->getResource());
            !mmbr.empty(); ++mmbr) {
         if (!mmbr->isGroup() &&
-            (!h->getSkill() || mmbr->hasSkill(h->getSkill()))) {
+            (!h->getSkill() || mmbr->hasSkill(h->getSkill(), d))) {
           auto my_eff =
               mmbr->getEfficiencyCalendar()
                   ? mmbr->getEfficiencyCalendar()->getValue(d ? d : getStart())