Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update c10s image #1334

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Update c10s image #1334

merged 2 commits into from
Jan 31, 2025

Conversation

rjeffman
Copy link
Member

This patch updates the base image for CentOS 10 Stream tests.

While fixing this issue, ansible-lint complained about the current yamllint configuration we used, so the PR has both commits.

@rjeffman rjeffman requested a review from t-woerner January 28, 2025 18:49
@rjeffman rjeffman marked this pull request as ready for review January 28, 2025 18:49
@rjeffman
Configure yamllint to be compatible with ansible-lint
91c4b83 
Current version of ansible-list pre-commit hook required changes in the
ansible-freeipa yamllint configuration and these changes triggered
issues in the current playbooks on roles and tests.

This patch adds the required changes to yaml lint configuration and
fixes the affected playbooks.

Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
@rjeffman
Use non-development CentOS 10 Stream image
8b4b22d 
As the official, non-development, CentOS 10 Stream image is available,
ansible-freeipa tests must use it instead of the centos-development one.
t-woerner
t-woerner approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@t-woerner t-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-woerner t-woerner merged commit f27b0e3 into freeipa:master Jan 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-woerner t-woerner t-woerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjeffman @t-woerner