Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Active users][Settings][Kebab] Add 'Reset password' option #215
[Active users][Settings][Kebab] Add 'Reset password' option #215
Changes from all commits
59143ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be improved later. But from UX perspective I'd rather see:
Reset the password for user $UID
. The reason is that in the "settings" page the user is not selected and it might be also a confirmation to the admin what user it applies to.Alternatively, I'd remove the "description" altogether as it, in current form, doesn't add more info than what is already showed in the title.
CC @bdellasc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your point, I think is more useful to refer to the current user (especially when this is an operation that is not made in bulk).
I can either change the title to the one that you are proposing (
Reset the password for user $UID
) or leave it as it is from now until we can discuss this with @bdellasc . I personally prefer the latter because it can bring an interesting UX perspective :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both works for me. So we can go with your preferred.