refactor: simplify {user,krbpolicy,pwpolicy}Utils #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Datetime parser to `ipaObjectUtils.convertApiObj` so that it can converted attributes defined by `dateValues`. With this it's no longer needed to use the datetime parsing in former objectToUser. This and the fact that there is no usage of `objectToUser` with the second parameter, allowed to replace `objectToUser` with `partialUserToUser` and `createEmptyUser` functions that are much imore simpler and reusable. The same for pw and krb policy objects. Signed-off-by: Petr Vobornik <pvoborni@redhat.com>
pvoborni
force-pushed
the
apiObjParsing
branch
from
4bb6a6b to
8e31d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Datetime parser to
ipaObjectUtils.convertApiObjso that it can converted attributes defined bydateValues.With this it's no longer needed to use the datetime parsing in former objectToUser.
This and the fact that there is no usage of
objectToUserwith the second parameter, allowed to replaceobjectToUserwithpartialUserToUserandcreateEmptyUserfunctions that are much imore simpler and reusable.The same for pw and krb policy objects.