ci: fail lint on any warning #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atm lint warnings do not fail the `npm run lint` check in CI. This allows invalid code to be merged without noticing. This change should help preventing merge of such changes. Signed-off-by: Petr Vobornik <pvoborni@redhat.com>
pvoborni
force-pushed
the
no-lint-warnings
branch
from
831d759 to
7707e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atm lint warnings do not fail the
npm run lintcheck in CI. This allows invalid code to be merged without noticing.This change should help preventing merge of such changes.
E.g. the ones that are being fixed in #268