Fix: Allow 'Force' without IP address (Hosts page only) #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a heads-up but service will need something similar if that wasn't already being done. |
This PR solution just affect the Hosts page. But we have it already implemented for Services. This is how it looks: It throws an error when DNs is not provided and succeeds if 'Force' option is checked. I guess it is correct? |
carma12
changed the title
|
Yup looks good for service. |
mreynolds389
approved these changes
Jan 29, 2025
Adding host should allow use of 'force' checkbox without IP address added, as the idea is to allow adding host objects that don't have DNS entries associated with them. Fixes: freeipa#624 Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
fix-hosts-force-option
branch
from
3612c40 to
35a50cf
Compare
|
The code has been corrected to adjust the behavior mentioned in this comment from the issue. |
|
Also the integration tests have been adapted to these changes. |
mreynolds389
approved these changes
Jan 30, 2025
As the way of creating new Hosts requires one more step (i.e. selecting the 'Force' checkbox), the integration tests need to be adapted to this. Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
fix-hosts-force-option
branch
from
60cfeb1 to
caa69b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding host should allow use of 'force' checkbox without IP address added, as the idea is to allow adding host objects that
don't have DNS entries associated with them.
Fixes: #624