Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IpaToggleGroup unit tests #650

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Conversation

duzda
Copy link
Contributor

@duzda duzda commented Feb 25, 2025

Adds some unit tests for the component that test almost all of the functionality. I have decided to not test ipaObject useEffect as that would be ugly to test, however we can cover that later.

Adds some unit tests for the component that test almost all of the
functionality. I have decided to not test ipaObject useEffect as that
would be ugly to test, however we can cover that later.

Signed-off-by: David Hanina <dhanina@redhat.com>
@duzda duzda requested a review from carma12 February 25, 2025 15:10
Copy link
Collaborator

@carma12 carma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nitpick: main object should be sudorule instead of user. The rest of it looks good.

Signed-off-by: David Hanina <dhanina@redhat.com>
@duzda duzda requested a review from carma12 February 27, 2025 07:04
Copy link
Collaborator

@carma12 carma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably you need to rebase and hopefully this will fix some failing tests. Otherwise, I can trigger them manually.

@duzda duzda merged commit 014bfba into freeipa:main Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants