change staking target extrinsic, closes #1570 #1623

shannonwells · 2023-06-27T22:39:01Z

Goal

The goal of this PR is to implement the change_staking_target extrinsic as specified in the Staking Rewards design document. The design document is updated as part of this PR to account for needed changes discovered during this implementation phase.

Closes #1570

Discussion

Checklist

shannonwells · 2023-06-29T18:41:35Z

pallets/capacity/src/lib.rs

-		AmountToUnstakeExceedsAmountStaked,
-		/// Attempting to unstake from a target that has not been staked to.
+		/// Amount to unstake or change targets is greater than the amount staked.
+		InsufficientStakingBalance,


This rename prompted the other two renames. I wanted to reuse this error, but adding OrChangeTargets would have made it too long.

shannonwells · 2023-06-29T18:43:19Z

pallets/capacity/src/lib.rs

 		/// Staker is attempting to stake an amount below the minimum amount.
-		InsufficientStakingAmount,
-		/// Staker is attempting to stake a zero amount.
+		StakingAmountBelowMinimum,


Because of the rename below, I felt InsufficientStakingAmount would be too easy to confuse with that.

shannonwells · 2023-06-29T18:43:56Z

pallets/capacity/src/lib.rs

@@ -302,31 +302,32 @@ pub mod pallet {
 		/// Staker attempted to stake to an invalid staking target.
 		InvalidTarget,
 		/// Capacity is not available for the given MSA.
-		InsufficientBalance,
+		InsufficientCapacityBalance,


This one was just to make it more specific, and to distinguish from InsufficientStakingBalance

shannonwells · 2023-06-29T18:46:13Z

pallets/capacity/src/lib.rs

-		InsufficientStakingAmount,
-		/// Staker is attempting to stake a zero amount.
+		StakingAmountBelowMinimum,
+		/// Staker is attempting to stake a zero amount.  DEPRECATED
 		ZeroAmountNotAllowed,


On working in this code again I felt like it was not necessary since we already have StakingAmountBelowMinimum which would include zero.

Updates to design doc Change some error names because they are being used by the new extrinsic

entry. feature: WIP update some starter code for do_retarget

Option<BalanceOf<T>> to BalanceOf<T> because the implementation was getting too hairy to justify the convenience.

shannonwells · 2023-07-06T20:48:48Z

designdocs/capacity_staking_rewards_implementation.md

 #[pallet:call_index(n+1)] // n = current call index in the pallet
 pub fn change_staking_target(
    origin: OriginFor<T>,
    from: MessageSourceId,
    to: MessageSourceId,
-    amount: Option<BalanceOf<T>>
+    amount: BalanceOf<T>


Implementing this as an option was not worth the trouble for the small gain in convenience.

shannonwells · 2023-07-06T20:50:01Z

integration-tests/capacity/replenishment.test.ts

@@ -101,7 +101,7 @@ describe("Capacity Replenishment Testing: ", function () {
      // new user/msa stakes to provider
      const userKeys = createKeys("userKeys");
      await fundKeypair(devAccounts[0].keys, userKeys, 5n * DOLLARS);
-      let [_, events] = await ExtrinsicHelper.stake(userKeys, stakeProviderId, userStakeAmt).fundAndSend();
+      let [_, events] = await ExtrinsicHelper.stake(userKeys, stakeProviderId, userStakeAmt, 'MaximumCapacity').fundAndSend();


integration tests needed to be changed to reflect the previous changes to the stake extrinsic.

The goal of this PR is to implement the `change_staking_target` extrinsic as specified in the Staking Rewards design document. The design document is updated as part of this PR to account for needed changes discovered during this implementation phase. Closes #1570

updates to design docs to use a capacity rewards interface Prototypes, make check working refinements to design doc Implement Staking Reward Eras basics (#1589) Implement the basic functionality of tracking and rotating Reward Era. Closes #1567 Does not include anything to do with the Reward Pool. Feat/staking rewards rewards provider #1572 (#1598) The goal of this PR is to implement a really basic version of the StakingRewardsProvider in the Capacity pallet and in the test mock, neither of which is actively used. Closes #1572 Does not include anything to do with setting and storing RewardPoolInfo when each new Era starts. change staking target extrinsic, closes #1570 (#1623) comments, capacity boost fn added to StakingRewardsProvider trait * Refactor staking type to go in StakingTargetDetails * Make some functions pass by reference (performance) * fix broken tests & calls use capacity_boost and StakingType to adjust capacity generation, add/adjust tests * Check from/to aren't the same when retargeting * Performance: move non-db checks to top when retargeting * Lots more tests * Fix a bug where we weren't setting the staking type on a retarget * Remove staking type from StakingAccountDetails * Fix broken tests from last commit Feat/reward pool history (#1710) Closes #1710 Feat/split stake extrinsic #1699 (#1717) The goal of this PR is to split the `stake` extrinsic into two: `stake` and `provider_boost` Closes #1707 Feat/split storage #1726 (#1744) The goal of this PR is to split up storage of boosting and maximized staking accounts, as well as store retarget history separately, which can store retargeting events for any type of staking. Closes #1726 fix e2e tests, correction to implementation design doc initialize storage for ProviderBoost on runtime upgrade Set ProviderBoost capacity generated and fix tests (#1947) * set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking. * Also Fixes some tests broken from the last rebase with main. Closes #1569 Update reward pool on `provider_boost` or `unstake` #1699 (#1948) The goal of this PR is to update the StakingRewardPool on a `provider_boost` or `unstake` extrinsic call. Closes #1699 Implement rewards calculation formula #1941 (#1956) The goal of this PR is to implement (but not really use yet) the chosen formula for calculation of a reward in a single Provider Boost Reward Era. Closes #1941 updates after rebase upsert staking history #1699 (#1963) The goal of this PR is to add and use storage for individual staking history so that rewards can be calculated and paid out. Benchmarks run to update capacity weights. Relates to #1699 Chores/update capacity benchmarks #1949 (#1966) The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created. Closes #1949 Feat/check unclaimed rewards 1969 (#1972) The goal of this PR is to implement `list_unclaimed_rewards`, and also one that is lighter weight, `has_unclaimed_rewards`, which returns a `bool` and which `unstake` extrinsic uses. Unstake now fails if there are any unclaimed rewards. Closes #1969 Closes #1578 Feat/reward pool refactor #1976 (#2005) The goal of this PR is to implement a "chunk" version of the overall reward pool history to reduce read/write load and hence weight for transactions and `on_initialize` when a new `RewardEra` needs to start. Part of #1976 Co-authored-by: Wil Wade <wil.wade@amplica.io> Revise Provider Boost implementation design doc #2016 (#2020) The goal of this PR is to review and update the implementation design doc in light of the chosen economic model, and to reflect some changes in behavior. Review of the design doc also fed back into the code itself. Some code is no longer needed. Closes #2016 Co-authored-by: Aramik <aramikm@gmail.com> E2e for new extrinsics (#2067) The goal of this PR is to add some e2e tests for the `provider_boost` extrinsic, and update the `change_staking_target` extrinsic after a rebase with main. Refactor reward era (#2069) The goal of this PR is primarily to pull RewardEra out of the Capacity Config and make it the same type everywhere. `claim_staking_rewards` extrinsic (#2080) Closes #1970 Capacity runtime api with list_unclaimed_rewards endpoint (#2088) The goal of this PR is to implement a capacity runtime api for the `list_unclaimed_rewards` endpoint. Closes #1698 Update Capacity README address the lint failure. updates after rebase with main Remove TODO since it's already been addressed. Add a minor test case to unstaking tests Add new extrinsics to Capacity README

shannonwells force-pushed the feat/change-staking-target-#1570 branch from 5e5f753 to fc010a2 Compare June 27, 2023 22:41

shannonwells commented Jun 29, 2023

View reviewed changes

shannonwells force-pushed the feat/capacity-staking-rewards-impl branch from 6bbbcfc to 8f335dc Compare July 3, 2023 22:14

shannonwells force-pushed the feat/change-staking-target-#1570 branch from bf21fec to ffe6aeb Compare July 3, 2023 22:14

shannonwells added 9 commits July 3, 2023 15:16

new extrinsic with parameter validation only and basic tests

9415219

Updates to design doc Change some error names because they are being used by the new extrinsic

please the linter

bdf1701

fix: when staking target details update amount is zero, delete the db

d398c6b

entry. feature: WIP update some starter code for do_retarget

update: change_staking_target parameter amount from

6a11e22

Option<BalanceOf<T>> to BalanceOf<T> because the implementation was getting too hairy to justify the convenience.

do_retarget_happy_path tests passing

a1472c8

Error condition tests passing except for unlock chunks

a10e65c

refactored tests & added new error check in extrinsic main

dc0df33

unlock chunks for changing staking targets implemented and passing tests

dde053f

benchmarks and needed event for extrinsic

554a40c

shannonwells force-pushed the feat/change-staking-target-#1570 branch from ffe6aeb to 554a40c Compare July 3, 2023 22:16

shannonwells marked this pull request as ready for review July 4, 2023 03:16

shannonwells requested a review from wilwade as a code owner July 4, 2023 03:16

shannonwells changed the title ~~Feat/change staking target #1570~~ DNM: Feat/change staking target #1570 Jul 4, 2023

shannonwells marked this pull request as draft July 4, 2023 03:17

end to end tests for change_staking_target

7eac0c1

shannonwells marked this pull request as ready for review July 6, 2023 20:46

shannonwells requested review from mattheworris, enddynayn and johnmela July 6, 2023 20:46

shannonwells changed the title ~~DNM: Feat/change staking target #1570~~ change staking target extrinsic, closes #1570 Jul 6, 2023

shannonwells commented Jul 6, 2023

View reviewed changes

remove comments no longer needed

47dbb54

shannonwells added a commit that referenced this pull request Oct 18, 2023

change staking target extrinsic, closes #1570 (#1623)

4660272

shannonwells added a commit that referenced this pull request Nov 7, 2023

change staking target extrinsic, closes #1570 (#1623)

597b6ab

shannonwells added a commit that referenced this pull request Dec 21, 2023

change staking target extrinsic, closes #1570 (#1623)

8023276

shannonwells added a commit that referenced this pull request Apr 17, 2024

change staking target extrinsic, closes #1570 (#1623)

aa820e9

shannonwells added a commit that referenced this pull request Apr 19, 2024

change staking target extrinsic, closes #1570 (#1623)

089994f

shannonwells added a commit that referenced this pull request Apr 22, 2024

change staking target extrinsic, closes #1570 (#1623)

f2fc5c7

shannonwells added a commit that referenced this pull request Apr 22, 2024

change staking target extrinsic, closes #1570 (#1623)

1daab3f

shannonwells added a commit that referenced this pull request Apr 23, 2024

change staking target extrinsic, closes #1570 (#1623)

deb3642

shannonwells added a commit that referenced this pull request May 3, 2024

change staking target extrinsic, closes #1570 (#1623)

c0e309e

shannonwells added a commit that referenced this pull request May 6, 2024

change staking target extrinsic, closes #1570 (#1623)

2317a92

shannonwells added a commit that referenced this pull request May 14, 2024

change staking target extrinsic, closes #1570 (#1623)

ca19641

shannonwells added a commit that referenced this pull request May 21, 2024

change staking target extrinsic, closes #1570 (#1623)

994eed0

shannonwells added a commit that referenced this pull request May 22, 2024

change staking target extrinsic, closes #1570 (#1623)

0c66957

shannonwells added a commit that referenced this pull request Jun 12, 2024

change staking target extrinsic, closes #1570 (#1623)

d63b520

shannonwells added a commit that referenced this pull request Jun 25, 2024

change staking target extrinsic, closes #1570 (#1623)

fbb8848

shannonwells added a commit that referenced this pull request Jun 25, 2024

change staking target extrinsic, closes #1570 (#1623)

dd716cd

shannonwells added a commit that referenced this pull request Jul 12, 2024

change staking target extrinsic, closes #1570 (#1623)

acf73fb

shannonwells added a commit that referenced this pull request Jul 18, 2024

change staking target extrinsic, closes #1570 (#1623)

806bd9e

shannonwells added the Provider Boosting label Jul 19, 2024

shannonwells added a commit that referenced this pull request Jul 23, 2024

change staking target extrinsic, closes #1570 (#1623)

7cfc638

shannonwells added a commit that referenced this pull request Oct 9, 2024

change staking target extrinsic, closes #1570 (#1623)

e1c60a0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change staking target extrinsic, closes #1570 #1623

change staking target extrinsic, closes #1570 #1623

shannonwells commented Jun 27, 2023 •

edited

Loading

shannonwells Jun 29, 2023 •

edited

Loading

shannonwells Jun 29, 2023 •

edited

Loading

shannonwells Jun 29, 2023

shannonwells Jun 29, 2023 •

edited

Loading

shannonwells Jul 6, 2023

shannonwells Jul 6, 2023

change staking target extrinsic, closes #1570 #1623

change staking target extrinsic, closes #1570 #1623

Conversation

shannonwells commented Jun 27, 2023 • edited Loading

Goal

Discussion

Checklist

shannonwells Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

shannonwells Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

shannonwells Jun 29, 2023

Choose a reason for hiding this comment

shannonwells Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

shannonwells Jul 6, 2023

Choose a reason for hiding this comment

shannonwells Jul 6, 2023

Choose a reason for hiding this comment

shannonwells commented Jun 27, 2023 •

edited

Loading

shannonwells Jun 29, 2023 •

edited

Loading

shannonwells Jun 29, 2023 •

edited

Loading

shannonwells Jun 29, 2023 •

edited

Loading