Replace the cgi module by vendoring used functions #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilioid
requested changes
Feb 13, 2025
timhallmann
force-pushed
the
drop_cgi
branch
from
26bbdf2 to
488d288
Compare
Certainly, I've only recently switched to 3.13 myself, so this was the first time I noticed that.
Makes sense, all done. In my defense: The missing type hints weren't that noticeable thanks to pyright correctly inferring everything. ;) |
timonegk
reviewed
Feb 14, 2025
Python 3.13 dropped the deprecated cgi module. Remove the module and include the relevant function to parse the content header.
timhallmann
force-pushed
the
drop_cgi
branch
from
488d288 to
3b952d8
Compare
lilioid
approved these changes
Feb 14, 2025
|
@timhallmann Thanks once again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 dropped the deprecated cgi module. Remove the module and include the relevant function to parse the content header.
This could be implemented differently, e.g. the Python docs mention using
email.message.EmailMessage. However, this approach seems a bit more natural in this instance.