Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharpx.Collections namespace #190

Merged
merged 1 commit into from
Dec 15, 2012
Merged

FSharpx.Collections namespace #190

merged 1 commit into from
Dec 15, 2012

Conversation

jackfoxy
Copy link
Contributor

FSharpx.Collections
FSharpx.Collections.Mutable

FSharpx.Collections
FSharpx.Collections.Mutable
@jackfoxy
Copy link
Contributor Author

First progress on #169

Almost a non-breaking change, by adding AutoOpen of new namespaces to FSharpx.Core AssemblyInfo.

But strangely some of the files in CSharpTests had to have using FSharpx.Collections added when previously they worked without using FSharpx; Something about C# interop I do not understand.

forki added a commit that referenced this pull request Dec 15, 2012
FSharpx.Collections namespace
@forki forki merged commit 37fdb99 into fsprojects:master Dec 15, 2012
@jackfoxy
Copy link
Contributor Author

@forki Does not appear to be part of build 1.6.130 (the FSharpx.Collections namespace is not available). Are you saving this for 1.7?

forki added a commit that referenced this pull request Dec 18, 2012
@forki
Copy link
Member

forki commented Dec 18, 2012

It's part of 1.6.132

@jackfoxy
Copy link
Contributor Author

Were the changes in 37fdb99 for src/FSharpx.Core/AssemblyInfo.fs not included in the 1.6.132 build? When I test a project referencing a local build of FSharpx it auto-opens Collections, but when I reference 1.6.132 it does not auto-open Collections.

@forki
Copy link
Member

forki commented Dec 19, 2012

mhm strange. Maybe there is a difference in the files? This can be on your or on my side. I'll check my repo for uncommited / ignored files.

@jackfoxy
Copy link
Contributor Author

Try installing FSharpx 1.6.132 to some project of yours from NuGet. FSharpx.Collections is available, but not auto-loaded by opening just FSharpx.

@forki
Copy link
Member

forki commented Dec 20, 2012

yep the missing auto-open caused 37fdb99

@ovatsus
Copy link

ovatsus commented Dec 20, 2012

Why do we want to autoopen FSharpx.Collections? Doesn't that goes against the purpose of separating them into a subnamespace in the first place?

@jackfoxy
Copy link
Contributor Author

@ovatsus 1. Auto-open makes this not a breaking change. 2. Microsoft.FSharp.Collections also auto-opens (or something similar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants