-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSharpx.Collections namespace #190
Conversation
FSharpx.Collections FSharpx.Collections.Mutable
First progress on #169 Almost a non-breaking change, by adding AutoOpen of new namespaces to FSharpx.Core AssemblyInfo. But strangely some of the files in CSharpTests had to have using FSharpx.Collections added when previously they worked without using FSharpx; Something about C# interop I do not understand. |
@forki Does not appear to be part of build 1.6.130 (the FSharpx.Collections namespace is not available). Are you saving this for 1.7? |
It's part of 1.6.132 |
Were the changes in 37fdb99 for src/FSharpx.Core/AssemblyInfo.fs not included in the 1.6.132 build? When I test a project referencing a local build of FSharpx it auto-opens Collections, but when I reference 1.6.132 it does not auto-open Collections. |
mhm strange. Maybe there is a difference in the files? This can be on your or on my side. I'll check my repo for uncommited / ignored files. |
Try installing FSharpx 1.6.132 to some project of yours from NuGet. FSharpx.Collections is available, but not auto-loaded by opening just FSharpx. |
yep the missing auto-open caused 37fdb99 |
Why do we want to autoopen FSharpx.Collections? Doesn't that goes against the purpose of separating them into a subnamespace in the first place? |
@ovatsus 1. Auto-open makes this not a breaking change. 2. Microsoft.FSharp.Collections also auto-opens (or something similar). |
FSharpx.Collections
FSharpx.Collections.Mutable