Some performance optimization #40
Conversation
|
Non-Windows CI failed... It says "You can resolve the problem by installing the 'X64' .NET." |
|
Let me sniff around this a bit. Not sure what that might be. FWIW it's the first time I've seen this and I've built both on Win and Linux. I have a Mac Mini M1 bolted under my desk so I could try it there too. @Thorium without knowing one way or other, I wonder if the language version has anything to do with this... maybe the fact that it's still building on .NET 6? FWIW - This "going back to move forward" interval will be a bit tenuous as I get to know this code base more closely. |
|
I think I see what's going on - though I'm still unsure why it's missing x64 - other than it's just so old - maybe it should be "macos-14" now to pick up ARM? I'm not even sure we need to go that far with this project. I just built and ran tests for your fork on my Mac Mini M1 and got two warnings and 0 errors. ✅ So I'm going to push this onward. 🎉 If I knew more about how far down the ARM64/MacOS rabbit hole GitHub Actions went, I'd matrix it in. But given that most build verification schemes I've seen deal with Linux and Windows and leave it at that - I'm inclined to do the same. I'll mull it over and see if Don wants to weigh in before I make a hard decision one way or other. |
|
Yes, I think there has been some issues with "-latest" being not stable in
Mac (and even Ubuntu), and maybe hard-coded version would work better.
…On Wed, Feb 19, 2025 at 9:04 PM Houston Haynes ***@***.***> wrote:
Merged #40 <#40> into dev.
—
Reply to this email directly, view it on GitHub
<#40 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABX726JJ7HZXZXY5CGX3RD2QTWVXAVCNFSM6AAAAABXJCKU3SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGM3TCOBQGI3TMMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
OK - duly noted. There are other aspects of the GA workflows here that leave me scratching my head (like how did they determine that building release off of dev was a good idea?) so I plan to make some garden-variety additions like auto-gen of release notes and rationalizing the release flow off of tags, etc. I've been hesitant to make those changes while forking the repo and now that it's more-or-less in-place I'll start making some of those changes so that a more recognizable semantic versioning process can been made more plain. |
Some minor performance optimizations: