neomake#utils#ExpandArgs: return a copy

fuine · Feb 23, 2018 · 3ec9f99 · 3ec9f99
1 parent fb6cf68
commit 3ec9f99
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/autoload/neomake.vim b/autoload/neomake.vim
@@ -700,7 +700,7 @@ function! s:command_maker_base._bind_args() abort dict
     endif
     let args_is_list = type(args) == type([])
     if args_is_list
-        call neomake#utils#ExpandArgs(args)
+        let args = neomake#utils#ExpandArgs(args)
     endif
     let self.args = args
 endfunction

diff --git a/autoload/neomake/utils.vim b/autoload/neomake/utils.vim
@@ -471,7 +471,7 @@ function! neomake#utils#ExpandArgs(args) abort
     " \\% is expanded to \\file.ext
     " %% becomes %
     " % must be followed with an expansion keyword
-    let ret = map(a:args,
+    let ret = map(copy(a:args),
                 \ 'substitute(v:val, '
                 \ . '''\(\%(\\\@<!\\\)\@<!%\%(%\|\%(:[phtre]\+\)*\)\ze\)\w\@!'', '
                 \ . '''\=(submatch(1) == "%%" ? "%" : expand(submatch(1)))'', '

diff --git a/tests/utils.vader b/tests/utils.vader
@@ -328,8 +328,7 @@ Execute (neomake#utils#ExpandArgs):
   \ '\~',
   \ ]
 
-  call neomake#utils#ExpandArgs(args)
-  AssertEqual expected_args, args
+  AssertEqual expected_args, neomake#utils#ExpandArgs(args)
   AssertEqual isk, &iskeyword
   bwipe