-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added actor for cylinder #959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ManishReddyR,
Thank you for this PR. Overall, it looks good.
- Can you add some unit tests ?
- There are some formatting issue( e.g: https://github.com/fury-gl/fury/actions/runs/12846827886/job/35825810717?pr=959#step:4:179). Can you check that and fix all of them. Thank you !
Also, it would be great to have a screenshot (with and without orientation and color) |
Hi @ManishReddyR, PR looks good! |
Also, comment the snapshot part for now until we find a fix for this function |
TEST: Adding uni tests for square actor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ManishReddyR,
See my review below. Please, pay attention to details if you want your PR to be merged fast.
Thank you
Hi @skoudoro Thank you |
in this case, it is ok. But usually, better to split in multiple PR |
Hello @skoudoro Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, see below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! all good, merging !
Tried actor for cylinder