Use Proper File Separator for OS #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fwilhe2 Any updates? |
fwilhe2
reviewed
Feb 3, 2025
| @@ -33,29 +33,30 @@ async function run(): Promise<void> { | |||
| if (installNative) { | |||
| const ktNativePath = await tc.downloadTool(nativeDownloadUrl(version)) | |||
| core.debug(`Downloaded Kotlin Native ${version} to ${ktNativePath}`) | |||
| core.exportVariable('KOTLIN_NATIVE_HOME', ktNativePath) | |||
There was a problem hiding this comment.
I don't understand how this is related to the pr.
There was a problem hiding this comment.
It's removing a duplicate statement. It does the same thing already below. I just forgot to include that in the description.
fwilhe2
reviewed
Feb 3, 2025
|
|
||
| const ktNativePathExtractedFolder = await extractNativeArchive(ktNativePath) | ||
| nativeCachedPath = await tc.cacheDir(ktNativePathExtractedFolder, 'kotlin-native', version) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| const s = IS_WINDOWS ? '\\' : '/' |
There was a problem hiding this comment.
would path.sep work instead? https://nodejs.org/docs/latest/api/path.html#pathsep
|
Hi @gmitch215 sorry for not getting back to you earlier, thanks for your contribution. I have not been aware of issues with this before, the action has tests that run on windows runners, is this really an issue? I think windows is just fine with using Apart from that, there are a few things
Can you take care of this? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
\on Windows when exporting to environment variable and to PATH, which should fix some issues on Windows.