Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli - give sensible printout for unknown file types #204

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

lnevay
Copy link
Contributor

@lnevay lnevay commented Oct 28, 2024

Previously manifested as undefined variable exception eventually and wasn't clear what the cause was without debugging.

lnevay and others added 2 commits October 28, 2024 15:08
…y manifested as undefined variable exception eventually and wasn't clear what the cause was without debugging.
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 74.11%. Comparing base (1e4f24c) to head (974db41).
Report is 131 commits behind head on main.

Files with missing lines Patch % Lines
src/pyg4ometry/cli.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   74.13%   74.11%   -0.03%     
==========================================
  Files         157      157              
  Lines       22712    22720       +8     
==========================================
  Hits        16838    16838              
- Misses       5874     5882       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboogert stewartboogert merged commit 278b182 into g4edge:main Oct 31, 2024
17 checks passed
@lnevay lnevay deleted the cli-fix-exception branch January 4, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants