express-url-params HW #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenayres
reviewed
Oct 9, 2018
views/show.ejs
Outdated
|
|
||
| The <%= mission.name %> Lanches on <%= mission.launchDate %>, Operated by <%= mission.operator %> . The type of mission will be a <%=mission.missionType%> | ||
|
|
||
| <img src="http://www.wallpaperbetter.com/wallpaper/15/951/740/curiosity-rover-mars-nasa-alien-landscape-robot-machine-hd-1080P-wallpaper-middle-size.jpg"> |
There was a problem hiding this comment.
instead of hard-coding in one image, try adding an image in each object in the data under "img", and have the images change accordingly on the show page
|
Yep just figured out how to do that, I’ll go back and fix
On Tue, Oct 9, 2018 at 12:11 PM Reuben Ayres ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In views/show.ejs
<#3 (comment)>
:
> @@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <title></title>
+</head>
+<body>
+
+<h1>Missions Show Page</h1>
+
+The <%= mission.name %> Lanches on <%= mission.launchDate %>, Operated by <%= mission.operator %> . The type of mission will be a <%=mission.missionType%>
+
+<img src="http://www.wallpaperbetter.com/wallpaper/15/951/740/curiosity-rover-mars-nasa-alien-landscape-robot-machine-hd-1080P-wallpaper-middle-size.jpg">
instead of hard-coding in one image, try adding an image in each object in
the data under "img", and have the images change accordingly on the show
page
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfHbYoBRSX5tPZeSbs6IdEaUf-2i8OQ1ks5ujNjagaJpZM4XTamj>
.
--
Best wishes,
Josh.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add images for others