-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH workflow #54
Add GH workflow #54
Conversation
This PR is ready for review. This PR aims to resolve #24 and #53. The GitHub workflow
Release processFrom past discussions, it sounds like we agree to use Gitflow / Hubflow for this repo. Here is what the release protocol could be:
|
@jaeddy The npmjs package below has been created automatically using the GH Action proposed in this PR. https://www.npmjs.com/package/gh-openapi-docs-test This package has been generated when I created this GH release https://github.com/tschaffter/gh-openapi-docs/releases/tag/20200913-3 Here is the GH Action run that shows the logs https://github.com/tschaffter/gh-openapi-docs/actions/runs/252577012 |
Thanks, @tschaffter! Is it straightforward to modify the workflow so that For the release process, it'd be nice to have steps (4) and (5) automated (triggered whenever a release branch is merged into |
@jaeddy The GH worflow now runs for commits pushed to all branches
If you agree, let's merge this PR to switch to GitHub workflow for CI/CD. I'll then open a second PR to address what you describe above. |
Thanks, @tschaffter! Just to clarify, the workflow will (a) run tests on all branches; but (b) only publish when a release is created (i.e., not for every branch)? |
Correct! The job
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
Tasks to perform in this workflow: