-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read input images from real-time dicom export #47
Conversation
…st class image class
Awesome!! I'll try to find some scanner time next week to test this out. |
python3-pip | ||
python3-pip \ | ||
python3-setuptools \ | ||
dcm2niix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps install this from their github release directly. see the instructions in this binaries section: https://github.com/ReproNim/neurodocker/blob/24d84b149b02e349de49398438299f9a2a712dec/neurodocker/templates/dcm2niix.yaml#L13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there specific reason we'd think the apt-gettable version isn't sufficient? i'd rather not increase the build time unless we have to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not always up to date. you can check how many revisions it lags by.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this shouldn't add any build time. did you see the instructions in the binaries section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah gotcha. i guess my remaining question is whether there are specific concerns with a lagged version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think for purpose of this PR less of a concern. this is a non-trivial conversion. i would worry if someone tries to use multi-echo data and more generally if this works well across scanners. for purpose of your target group this is less of a concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense. i'll make an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only skimmed the code, but looked reasonable.
Added a couple suggestions to help us understand what's going on when dcm2niix fails and has to retry. Otherwise, code looks good. Will hold off on approval until I've confirmed it's working on the scanner. |
Cool. That shouldn't be an issue, but will test it tonight. |
Confirmed working on xa30. |
This adds the functionality to read input images from a folder that's the target of a real-time dicom export from the scanner. It's designed to support the Siemens BOLD add-in.
I've also updated the regression test and example data to include a dicom test.