Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read input images from real-time dicom export #47

Merged
merged 20 commits into from
Mar 12, 2025
Merged

Conversation

ohinds
Copy link
Collaborator

@ohinds ohinds commented Feb 13, 2025

This adds the functionality to read input images from a folder that's the target of a real-time dicom export from the scanner. It's designed to support the Siemens BOLD add-in.

I've also updated the regression test and example data to include a dicom test.

@pwighton
Copy link
Contributor

Awesome!! I'll try to find some scanner time next week to test this out.

@ohinds ohinds marked this pull request as ready for review March 5, 2025 19:05
@ohinds ohinds requested review from satra and pwighton March 5, 2025 19:05
@ohinds ohinds changed the title WIP: Read input images from real-time dicom export Read input images from real-time dicom export Mar 5, 2025
python3-pip
python3-pip \
python3-setuptools \
dcm2niix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps install this from their github release directly. see the instructions in this binaries section: https://github.com/ReproNim/neurodocker/blob/24d84b149b02e349de49398438299f9a2a712dec/neurodocker/templates/dcm2niix.yaml#L13

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there specific reason we'd think the apt-gettable version isn't sufficient? i'd rather not increase the build time unless we have to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not always up to date. you can check how many revisions it lags by.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this shouldn't add any build time. did you see the instructions in the binaries section?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah gotcha. i guess my remaining question is whether there are specific concerns with a lagged version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think for purpose of this PR less of a concern. this is a non-trivial conversion. i would worry if someone tries to use multi-echo data and more generally if this works well across scanners. for purpose of your target group this is less of a concern.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense. i'll make an issue.

Copy link
Contributor

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only skimmed the code, but looked reasonable.

@pwighton
Copy link
Contributor

pwighton commented Mar 7, 2025

Added a couple suggestions to help us understand what's going on when dcm2niix fails and has to retry. Otherwise, code looks good. Will hold off on approval until I've confirmed it's working on the scanner.

@ohinds
Copy link
Collaborator Author

ohinds commented Mar 10, 2025

@satra @pwighton a note for y'all. to take advantage of features in newer g++, i bumped the base image here to 24.04. i don't think that should be a huge issue but if you wanted to take a look at that last commit again that might make sense.

@pwighton
Copy link
Contributor

Cool. That shouldn't be an issue, but will test it tonight.

@pwighton
Copy link
Contributor

Confirmed working on xa30.

@ohinds ohinds merged commit c2e09a9 into master Mar 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants