Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extension ports configurable via helm values #985

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Make extension ports configurable via helm values #985

merged 2 commits into from
Feb 20, 2025

Conversation

ScheererJ
Copy link
Member

How to categorize this PR?

/area networking
/kind enhancement
/platform openstack

What this PR does / why we need it:

Make extension ports configurable via helm values.

In certain scenarios, e.g. in the autonomous cluster use case, multiple extensions may run side-by-side in the host network. In this case, they cannot use the same ports. Therefore, it should be possible to inject the usable ports from outside via helm values.

Which issue(s) this PR fixes:
Part of gardener/gardener#2906

Special notes for your reviewer:

Release note:

The ports used by the extension can now be specified via helm values.

@ScheererJ ScheererJ requested review from a team as code owners February 18, 2025 15:07
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 18, 2025
@ScheererJ ScheererJ mentioned this pull request Feb 18, 2025
Open
38 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 18, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 18, 2025
@ScheererJ ScheererJ force-pushed the enhancement/make-extension-port branch from 3b60086 to 9fcf8a4 Compare February 19, 2025 14:01
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2025
@ScheererJ ScheererJ force-pushed the enhancement/make-extension-port branch from 9fcf8a4 to 084f8a1 Compare February 19, 2025 14:06
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 19, 2025
kon-angelo
kon-angelo approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 20, 2025
@kon-angelo kon-angelo merged commit f7f73f5 into gardener:master Feb 20, 2025
12 checks passed
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 20, 2025
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScheererJ @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot