Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM 19.1.3 #133

Merged
merged 7 commits into from
Jan 28, 2025
Merged

LLVM 19.1.3 #133

merged 7 commits into from
Jan 28, 2025

Conversation

garymm
Copy link
Owner

@garymm garymm commented Jan 28, 2025

fixes build on MacOS

@oliverlee
Copy link
Collaborator

not sure why clang 18 can't find libtinfo5

any reason not to use llvm 19? then you can remove the libtinfo install step

@oliverlee
Copy link
Collaborator

oliverlee commented Jan 28, 2025

it might be good to remove the llvm patching step as well

@garymm garymm changed the title LLVM 18 LLVM 19.1.3 Jan 28, 2025
@garymm
Copy link
Owner Author

garymm commented Jan 28, 2025

Ugh I don't understand what's going on. I will look tomorrow

@oliverlee
Copy link
Collaborator

@oliverlee
Copy link
Collaborator

and this
https://github.com/garymm/starflate/blob/master/WORKSPACE.bazel#L112-L116

I was using 19.1.0 (I think). I might have also run into the whitelist issue -- I'll try and check tomorrow.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (1cd6846) to head (e08387e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   82.40%   73.95%   -8.45%     
==========================================
  Files          16       16              
  Lines         625      695      +70     
  Branches       39       65      +26     
==========================================
- Hits          515      514       -1     
- Misses         92      138      +46     
- Partials       18       43      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garymm garymm enabled auto-merge (squash) January 28, 2025 19:36
@garymm garymm merged commit ef27d6b into master Jan 28, 2025
14 of 15 checks passed
@garymm garymm deleted the garymm/update-bazel branch January 28, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants