-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM 19.1.3 #133
LLVM 19.1.3 #133
Conversation
not sure why clang 18 can't find libtinfo5 any reason not to use llvm 19? then you can remove the libtinfo install step |
it might be good to remove the llvm patching step as well |
Ugh I don't understand what's going on. I will look tomorrow |
you should be able to remove https://github.com/garymm/starflate/blob/master/WORKSPACE.bazel#L28-L41 |
and this I was using 19.1.0 (I think). I might have also run into the whitelist issue -- I'll try and check tomorrow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 82.40% 73.95% -8.45%
==========================================
Files 16 16
Lines 625 695 +70
Branches 39 65 +26
==========================================
- Hits 515 514 -1
- Misses 92 138 +46
- Partials 18 43 +25 ☔ View full report in Codecov by Sentry. |
fixes build on MacOS