-
Notifications
You must be signed in to change notification settings - Fork 172
Fixed altoclef crashing if quitting the world while the task is running. #340
base: 1.19.4--marvion
Are you sure you want to change the base?
Changes from 31 commits
9526ed1
59d54fc
e03c02f
2d05070
ce525c7
bb4f735
c2995dc
8f405d0
68933f0
7c1a7d1
0d0de54
a3281f2
f7f66e7
5aedee5
e958ae2
ed750cc
0ec5a5e
9987e57
12111aa
22bad21
7567dce
067222e
32915bb
98c8492
824d4e0
fc7a73d
a7c2fdc
eb2f03c
9694872
7414776
35251c4
3f5a95f
baac615
65d7f6e
138325a
b752e3c
4c020bc
ed3a98c
e983979
e1d7e04
b4d15c0
4457e5f
d4760a1
ad5b7d3
909e685
f0f3742
9cc1945
81abac2
af5ca7a
e49cdc2
af883fe
660ac0a
4cfb6a7
d3ed92e
977ba7c
ac3ecff
ed1c1eb
0563add
6170b93
24a856f
aaad871
f335f6f
779e330
b703088
e5cb987
f7fcc63
034a236
aae919f
47c3562
0aee424
6639a3d
e5ffe6f
a0d31a9
376bf54
45f80cf
310e362
5daf183
d5d2936
f743d5c
af5454c
92607f4
eeb695e
72e186a
82621bd
f37a29d
b938352
1749509
84fe018
0de20c5
ed04ff2
eb03388
42a4b07
f4b3743
7237bfa
8779989
07f6dfd
c9833a8
c05f051
785c5ae
e50ae10
d22647d
4b32c14
1026661
2f51bce
c7e3ce4
3f8d2f7
a4dee52
5b34062
7dde6b5
063e38f
7cbaa20
92a2991
6a39827
a070139
f701800
b51a26e
5a0cd35
82c92e8
2c99b73
0663bde
d97fa92
be536ae
71549bf
7cfd71b
9f503ec
caf203e
b3554b5
bd13a4c
da3dce5
2ca4196
1713539
e45566e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,8 @@ group = project.maven_group | |
repositories { | ||
mavenCentral() | ||
maven { | ||
name = "gaucho-matrero-repo" | ||
url = "https://gaucho-matrero.github.io/maven/" | ||
name = "MarvionKiritoRepo" | ||
url = "https://github.com/MarvionKirito/maven" | ||
} | ||
flatDir { | ||
dirs '../baritone/dist' | ||
|
@@ -43,14 +43,14 @@ dependencies { | |
shadow('com.fasterxml.jackson.core:jackson-databind:2.15.0-rc1') | ||
|
||
// Thank you georgeagostino for fixing my garbage | ||
// if (getProject().hasProperty("altoclef.development")) { | ||
// Must run build from baritone-plus once | ||
modImplementation 'baritone-api-fabric:baritone-unoptimized-fabric-1.19.4-beta1' | ||
include "baritone-api-fabric:baritone-unoptimized-fabric-1.19.4-beta1" | ||
//} else { | ||
// modImplementation "cabaletta:baritone-unoptimized-fabric:1.18.2" | ||
// include "cabaletta:baritone-unoptimized-fabric:1.18.2" | ||
//} | ||
if (getProject().hasProperty("altoclef.development")) { | ||
// Must run build from baritone-plus once | ||
modImplementation 'baritone-api-fabric:baritone-unoptimized-fabric-1.19.4-beta1' | ||
include "baritone-api-fabric:baritone-unoptimized-fabric-1.19.4-beta1" | ||
} else { | ||
modImplementation "cabaletta:baritone-unoptimized-fabric:1.19.4-beta1" | ||
include "cabaletta:baritone-unoptimized-fabric:1.19.4-beta1" | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure you can just grab Cabaletta like this. Alto uses its own baritone and as such, needs the unoptimized jar. That's probably why the gradle is failing on the workflow. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More specifically, it won't be able to actually use the cabaletta baritone because our baritone actually references altoclef There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's for my maven. |
||
//modImplementation 'baritone-api-fabric:baritone-api-fabric:1.6.3' | ||
//implementation files('baritone-plus/build/libs/baritone-unoptimized-fabric-1.6.3.jar') | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ minecraft_version=1.19.4 | |
yarn_mappings=1.19.4+build.1 | ||
loader_version=0.14.18 | ||
# Mod Properties | ||
mod_version=1.19.4-beta1 | ||
mod_version=1.19.4-beta2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You version the mod as beta2 but in the baritone settings you look for beta1. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just changed the release title of my baritone. |
||
maven_group=gaucho-matrero.altoclef | ||
archives_base_name=altoclef | ||
# Dependencies | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the maven repo on gauchomatrero. If you were to ever leave the project, we would be ******
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we get this working, I will merge this and it will become main