fix(GH-19): Split arguments that are known to contain a space

gavanlamb · Jun 16, 2024 · 2cc7a2d · 2cc7a2d
1 parent 541f226
commit 2cc7a2d
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 31 deletions.
diff --git a/__tests__/services/dotnetService.test.ts b/__tests__/services/dotnetService.test.ts
@@ -117,13 +117,20 @@ describe("listOutdatedPackages", () => {
             '--include-prerelease',
             '--highest-minor',
             '--highest-patch',
-            '--source source1',
-            '--source source2',
-            '--config nuget.config',
-            '--framework net5.0',
-            '--framework net6.0',
-            '--format json',
-            '--verbosity q'
+            '--source',
+            'source1',
+            '--source',
+            'source2',
+            '--config',
+            'nuget.config',
+            '--framework',
+            'net5.0',
+            '--framework',
+            'net6.0',
+            '--format',
+            'json',
+            '--verbosity',
+            'q'
         ];
 
         const { listOutdatedPackages } = await import("../../src/services/dotnetService");
@@ -249,8 +256,10 @@ describe("listOutdatedPackages", () => {
             'list',
             'package',
             '--outdated',
-            '--format json',
-            '--verbosity q'
+            '--format',
+            'json',
+            '--verbosity',
+            'q'
         ];
 
         const { listOutdatedPackages } = await import("../../src/services/dotnetService");
@@ -307,8 +316,10 @@ describe("listOutdatedPackages", () => {
             'list',
             'package',
             '--outdated',
-            '--format json',
-            '--verbosity q'
+            '--format',
+            'json',
+            '--verbosity',
+            'q'
         ];
 
         const { listOutdatedPackages } = await import("../../src/services/dotnetService");

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/services/dotnetService.ts b/src/services/dotnetService.ts
@@ -76,20 +76,24 @@ function getNuGetSourceArguments(): string[] {
     const values = getStringArrayInput('nuget-sources');
     const sources: string[] = [];
     for (const value of values){
-        sources.push(`--source ${value}`);
+        sources.push(`--source`);
+        sources.push(`${value}`);
     }
     return sources;
 }
 
 /**
  * Gets the packages-to-exclude argument from the action
- * @returns --exclude {packages} if the argument is set.
+ * @returns array containing '--config' and '{config}; if the argument is set.
  */
-function getNuGetConfigArgument(): string {
+function getNuGetConfigArgument(): string[] {
     const value = getStringInput('nuget-config-file-path');
-    if (value)
-        return `--config ${value}`;
-    return '';
+    const config: string[] = [];
+    if (value) {
+        config.push(`--config`);
+        config.push(`${value}`);
+    }
+    return config;
 }
 
 /**
@@ -100,7 +104,8 @@ function getFrameworkArguments(): string[] {
     const values = getStringArrayInput('frameworks');
     const sources: string[] = [];
     for (const value of values){
-        sources.push(`--framework ${value}`);
+        sources.push(`--framework`);
+        sources.push(`${value}`);
     }
     return sources;
 }
@@ -120,10 +125,12 @@ async function listOutdatedPackages(): Promise<Configuration> {
         getIncludeHighestMinorOnlyArgument(),
         getIncludeHighestPatchOnlyArgument(),
         ...getNuGetSourceArguments(),
-        getNuGetConfigArgument(),
+        ...getNuGetConfigArgument(),
         ...getFrameworkArguments(),
-        '--format json',
-        '--verbosity q'
+        '--format',
+        'json',
+        '--verbosity',
+        'q'
     ].filter(arg => arg !== '');
 
     debug(`Going to execute "dotnet ${args.join(" ")}"`);