Skip to content

Commit

Permalink
Merge pull request #24 from gavanlamb/fix/GH-23-fix-iso-8601
Browse files Browse the repository at this point in the history
fix(GH-23): Set time to ISO 8601 standard for started_at & completed_at
  • Loading branch information
gavanlamb authored Jun 16, 2024
2 parents 01403fa + 0364a87 commit 738df1d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
5 changes: 3 additions & 2 deletions __tests__/client/octokit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@ describe("createOctokitClient", () => {
const OctokitMock = jest.fn();
jest.doMock("octokit", () => ({ Octokit: OctokitMock }));

process.env.GITHUB_TOKEN = "test-token";
const token = "test-token";
process.env.GITHUB_TOKEN = token;

const { createOctokitClient } = await import("../../src/clients/octokit");
await createOctokitClient();

expect(OctokitMock).toHaveBeenCalledWith({
auth: "test-token"
auth: token
});
});

Expand Down
4 changes: 2 additions & 2 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/clients/githubChecksClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ async function createCheck(
details_url: undefined,
external_id: undefined,
status,
started_at: Date.now(),
started_at: new Date().toISOString(),
conclusion,
completed_at: Date.now(),
completed_at: new Date().toISOString(),
output: {
title,
summary: body,
Expand Down

0 comments on commit 738df1d

Please sign in to comment.