refactor(gear): move runtime parameter constants into gear-core #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hadn't noticed the compile error because of the fact that gear-core is a dev-dependency for Vara runtime. It can be fixed by moving it to regular dependencies. Is that a proper way to handle that or maybe constants should be moved entirely to a new crate like |
breathx
requested changes
Mar 13, 2025
| @@ -151,8 +152,8 @@ where | |||
| gas_multiplier: GasMultiplier::one(), | |||
| costs: Default::default(), | |||
| max_pages: MAX_WASM_PAGES_AMOUNT.into(), | |||
| outgoing_limit: 1024, | |||
| outgoing_bytes_limit: 64 * 1024 * 1024, | |||
| outgoing_limit: OUTGOING_LIMIT, | |||
There was a problem hiding this comment.
wdyt if we remove this constants from configs at all? or provide some default constructor with them not to miss anything, @grishasobol ?
There was a problem hiding this comment.
And remove runtime constants?
There was a problem hiding this comment.
ah ok. see now it's already removed.
what about ?
mailbox_threshold
max_reservations
max_pages
gas_multiplier and e.t.c
breathx
added
A3-gotissues
breathx
approved these changes
Mar 17, 2025
breathx
added
A0-pleasereview
breathx
requested changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves runtime parameter constants into a separate file under gear-core and then replaces all their definitions with the constant usage.