Make cache store configurable #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyjorgedev
force-pushed
the
configure-cache-store
branch
2 times, most recently
from
467f353 to
414c739
Compare
|
I even think that the default cache store for this package should be file but didn't want to do that change since there are already people using it |
heyjorgedev
force-pushed
the
configure-cache-store
branch
from
414c739 to
5d7d5b7
Compare
|
I am also facing this problem. We need to make the cache store configurable. Why maintainer are not merging this pull request. |
mariio46
approved these changes
Aug 6, 2024
|
Hi maintainer, is it possible to be merged ? |
|
It's been a while, merge the PR. People are eager 😄 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my project I use Redis as my default cache store, I noticed that the package right now uses cache (the default store) to not compute the same thing all over again, but I think doing a network request to Redis is expensive, by making the cache store configurable you can optimize this to use the "file" store.
Just an idea, on my project solved it by extending the service provider and making my changes, but the package is awesome and wanted to contribute with this idea back