Require explicit index checks or assertions #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many places in the code were using unchecked indexed access, which conflicts with many people's TypeScript configurations. We copy the hydrate.ts module directly into the generated code, so we will now check the rest of the generate module with the same strict configuration. An alternative approach would be to separate out the code we copy into the query builder into a more strict subset and keep the looser config for our own code, but I think stricter is better anyway. Most places just got the assertion treatment, but in a few places it was straightforward enough to actually do something more safe.
scotttrinh
commented
Feb 28, 2025
| @@ -272,7 +272,7 @@ function processLinks(types: JSONType[], modules: string[]): ProcessedSpec { | |||
|
|
|||
| link_objects.push(lobj); | |||
| link["has_link_object"] = true; | |||
| objtype["backlinks"][-1]["has_link_object"] = true; | |||
| objtype["backlinks"].at(-1)!["has_link_object"] = true; | |||
There was a problem hiding this comment.
@vpetrovykh This was the one major change I made across this whole refactor: was this the intention of this code path (update the last backlink in the array)? I think you can use a negative index on an array:
> const a = [];
undefined
> a[-1] = "beep";
'beep'
> a
[ '-1': 'beep' ]
But I doubt that's what you were trying to do here?
There was a problem hiding this comment.
Yeah, your fix is correct, I meant the last element of the array, not the actual index '-1'.
jaclarke
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many places in the code were using unchecked indexed access, which conflicts with many people's TypeScript configurations. We copy the hydrate.ts module directly into the generated code, so we will now check the rest of the generate package with the same strict configuration.
An alternative approach would be to separate out the code we copy into the query builder into a more strict subset and keep the looser config for our own code, but I think stricter is better anyway.
Most places just got the assertion treatment, but in a few places it was straightforward enough to actually do something more safe.