Extract the client from edgedb-cli #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need to wait for @tailhook's opinion on this. He'll be back in a few days. |
|
As I've written few minutes ago in geldata/gel-cli#112 (comment) this is more complex matter than just extracting the client. At a glance, your PR looks fine, but we need to figure out our general approach to the API and our steps to implement that. I'll try to spend more time on that this week. We can discuss the details on geldata/gel-cli#112. |
|
Merged. Thanks! I've also put #32 to track remaining issues with the client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the edgedb-client from edgedb-cli as a separate crate, so it can be used independently.
The first commit contains the unchanged modules copied from edgedb-cli. The second commit makes sequences public, so edgedb-cli can import them.
I'll send a follow up pull request against edgedb-cli to use this crate if this one gets accepted. (branch)
If you care about proper credit assignment in git, you'll need to change the author of the commit before merging, since I didn't actually write it.
relates to: geldata/gel-cli#112