Tweak handling of branches and database params #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoor
approved these changes
Apr 3, 2024
aljazerzen
force-pushed
the
fix/missing-exclusivity-check-in-conn-args
branch
from
aa459f9 to
7430771
Compare
|
I've changed how we handle database and branch in a few places, such that shared-client-tests test in edgedb-cli now passes: geldata/gel-cli#1252 |
aljazerzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing check for exclusivity between database and branch, also overrides both for compatibility between 5.x and non 5.x