Add version sort

gems-uff · Aug 16, 2024 · a952cef · a952cef
1 parent 859800d
commit a952cef
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/releasy/model.py b/releasy/model.py
@@ -68,13 +68,13 @@ def __lt__(self, other: ReleaseVersion):
             return False
 
         for a,b in zip(self.number, other.number):
-            if a > b:
-                return False
+            if a < b:
+                return True
 
         if a == b:
             return False
 
-        return True
+        return False
 
     def __le__(self, other: ReleaseVersion):
         return self < other or self == other

diff --git a/tests/test_model.py b/tests/test_model.py
@@ -54,7 +54,9 @@ def it_is_comparable(self):
         assert release_a.version != release_b.version 
 
         assert release_a.version < release_b.version 
+        assert release_a.version <= release_b.version 
         assert release_b.version > release_a.version 
+        assert release_b.version >= release_a.version 
 
         assert not (release_a.version < release_a2.version)
         assert not (release_a.version > release_a2.version)
@@ -65,8 +67,8 @@ def it_is_sortable(self):
         version_b = releaseFormat.parse("1.0.1")
         version_c = releaseFormat.parse("1.1.0")
         versions = [version_c, version_a, version_b]
-        # sorted_versions = sorted(versions)
-        # assert sorted_versions == [version_a, version_b, version_c] 
+        sorted_versions = sorted(versions)
+        assert sorted_versions == [version_a, version_b, version_c] 
 
 
 class DescribeSemanticVersioningFormat: